Skip to content

Conversation

@Helmi
Copy link

@Helmi Helmi commented Apr 7, 2025

Context

The datetime format for <environment_details> was weird and had the potential to confuse LLMs.

For example it used an international date format that was not defined and fell back to local. In my case (German) todays date output was 6.4.2025 which got confused by LLM for June 4th multiple times (instead of April 6th).

The forced time format of 12h which is completely not used in germany probably added to that confusion.

Implementation

I changed the output to output both, Zulu Time in a standard ISO Timestamp format as well as a local Time string containing the local time including offset as well as the Time Zone name.

Current Zulu Date/Time

2025-04-07T13:56:53.293Z

Current Local Date/Time

Mon Apr 07 2025 15:56:53 GMT+0200 (Mitteleuropäische Sommerzeit)

Get in Touch

@Helmi on Discord


Important

Fix datetime format in Cline.ts to include Zulu and local time with timezone details, updating tests accordingly.

  • Behavior:
    • getEnvironmentDetails in Cline.ts now outputs both Zulu Time and local time with timezone details.
  • Tests:
    • Updated getEnvironmentDetails test in Cline.test.ts to verify new datetime format output.
    • Mocked Date.prototype.getTimezoneOffset to simulate timezone in tests.

This description was created by Ellipsis for 027fdf9bf54f3e52772215896d5c3179695de949. It will automatically update as commits are pushed.

@Helmi Helmi requested review from cte and mrubens as code owners April 7, 2025 14:15
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug Something isn't working labels Apr 7, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 7, 2025
@Helmi Helmi force-pushed the fix-datetime-format branch from 027fdf9 to 95deea2 Compare April 8, 2025 05:14
@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: 276c75e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Helmi Helmi force-pushed the fix-datetime-format branch from 95deea2 to 276c75e Compare April 10, 2025 06:38
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Needs Review] in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

Thanks for your contribution. We apologize for letting your PR go so long without a review.

We've now shifted to a clearer issue-first workflow to avoid this kind of situation going forward. Please create an issue first if you'd like to revisit this again.

We truly appreciate your patience and would be happy to have you continue contributing.

@daniel-lxs daniel-lxs closed this May 27, 2025
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap May 27, 2025
@github-project-automation github-project-automation bot moved this from Needs Preliminary Review to Done in Roo Code Roadmap May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR - Needs Preliminary Review size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants