feat(benchmarks): add mention regex benchmark scripts and results #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| console.log(`Running benchmark for: ${name}`) | ||
|
|
||
| let totalMatches = 0 | ||
| const startTime = performance.now() |
Contributor
There was a problem hiding this comment.
Consider explicitly importing performance from perf_hooks to ensure compatibility with Node versions that don't have a global performance object.
| // Get the project root directory | ||
| const projectRoot = path.resolve(__dirname, "../..") | ||
|
|
||
| // Run the benchmark using ts-node |
Contributor
There was a problem hiding this comment.
The comment refers to ts-node, but the script uses 'tsx'. Please update the comment to accurately reflect the tool being used.
Suggested change
| // Run the benchmark using ts-node | |
| // Run the benchmark using tsx |
Member
|
Thank you for your contribution. We are closing this PR because we would like to have an issue created for this following our issue-first workflow. Please create an issue if you plan to revisit this. We truly appreciate your patience and would be happy to have you continue contributing. |
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
github-project-automation
bot
moved this from Needs Preliminary Review
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Because we run @-mention's regex every keystroke in chat area, we need tracking the change of regex performance when we add new feature to @-mention
Implementation
Screenshots
How to Test
Get in Touch
Important
Adds benchmarking scripts for
mentionRegexGlobalto track performance changes with various test cases and saves results for future reference.mention-regex-benchmark.tsto benchmarkmentionRegexGlobalfromcontext-mentions.ts.results/mention-regex-benchmark-[timestamp].mdandresults/mention-regex-benchmark-latest.md.run-mention-benchmark.jsfor easy command-line execution of the benchmark.mentionRegexincontext-mentions.tsto use separate patterns for paths, URLs, git hashes, and keywords.This description was created by
for 118c4f7. It will automatically update as commits are pushed.