Skip to content

Conversation

@ross
Copy link
Contributor

@ross ross commented Apr 8, 2025

Context

This PR bundles fixes & cleanup around rateLimitSeconds after https://github.com/RooVetGit/Roo-Code/pull/2376/files 🚢ed.

Implementation

The first commit shifts things to be soley driven off of the provider-specific version of rateLimitSeconds and can be found in 54b8e84. It also removes an unnecessary default value. This commit should have no user visible impact and is intended to make things more directly tied to the value's new location.

The second makes a pass through things removing all of the references to the original global rateLimitSeconds with the exception of the settings value itself since that needs to live on for now so that it can be migrated to the provider specific field 2151b5f. Afaik this commit should have no meaningful impact on the extension.

Screenshots

No user visible changes are intended.

How to Test

(copied from #2376 (comment))

Set a rate-limit in the advanced section before updating to this code. Update and see that the value you set is copied over to all of your profiles. You can then go into each profile and change the values to something that makes sense for the specific provider. Once saved the value should be tied to the provider.

If no value is set before you update, e.g. 0s, that 0s value will be copied to all the profiles as well.

Get in Touch

rwmcfa1

/cc #2376 as realted


Important

Refactor to remove global rateLimitSeconds and shift to provider-specific configuration.

  • Configuration Changes:
    • Remove global rateLimitSeconds from roo-code-defaults.ts and ClineProvider.ts.
    • Update Cline.ts to use apiConfiguration?.rateLimitSeconds instead of global rateLimitSeconds.
  • State Management:
    • Remove rateLimitSeconds handling from webviewMessageHandler.ts and ExtensionStateContext.tsx.
    • Update ExtensionMessage.ts and WebviewMessage.ts to remove rateLimitSeconds references.
  • Testing:
    • Update ClineProvider.test.ts to remove tests related to rateLimitSeconds.

This description was created by Ellipsis for 2151b5f. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: 43bbf84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 8, 2025
@ross
Copy link
Contributor Author

ross commented Apr 8, 2025

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Not sure if this one needs a changeset or not. It's definitely a patch-level change, but doesn't really have anything that I think would warrant mention in the CHANGELOG.

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2025
@mrubens mrubens merged commit 58149a0 into RooCodeInc:main Apr 8, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 8, 2025
@ross ross deleted the remove-stale-rate-limit branch April 8, 2025 15:24
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants