Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Apr 9, 2025

Important

Enhance rule file processing to follow symbolic links, ensuring symlinked files are included, with updated tests for verification.

  • Behavior:
    • readTextFilesFromDirectory in custom-instructions.ts now follows symbolic links to include symlinked files in rule processing.
    • Updates loadRuleFiles and addCustomInstructions to utilize the new symlink-following behavior.
  • Tests:
    • Adds test in custom-instructions.test.ts to verify symlink handling in loadRuleFiles.
    • Updates existing tests to mock isSymbolicLink and readlink for symlink scenarios.

This description was created by Ellipsis for 6e1c2b3. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2025

⚠️ No Changeset found

Latest commit: 6e1c2b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 9, 2025
const filePaths: string[] = []

for (const entry of entries) {
const fullPath = path.resolve(entry.parentPath || dirPath, entry.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-standard use of entry.parentPath in readTextFilesFromDirectory. Dirent objects from fs.readdir do not include this property by default. Consider documenting the custom use or calculating the full path via dirPath.

@mrubens mrubens merged commit c2fef2d into main Apr 9, 2025
19 checks passed
@mrubens mrubens deleted the follow_symlinks_for_rules branch April 9, 2025 02:52
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants