Skip to content

Conversation

@wkordalski
Copy link
Contributor

@wkordalski wkordalski commented Apr 10, 2025

Context & Implementation

If somebody uses direnv tool, the .direnv directory is created, that contains some data and especially some symlinks. Symlinks makes vsce to fail zipping the built VSIX.

Generally .direnv should not be added to the resulting VSIX, therefore I add it to .vscodeignore.

Maybe we should use "whitelist" strategy of defining what should be packaged instead of "blacklist"?

Screenshots

How to Test

Get in Touch

Discord handle: wkordalski


Important

Add .direnv/** to .vscodeignore to prevent packaging issues with vsce due to symlinks.

  • Behavior:
    • Add .direnv/** to .vscodeignore to exclude .direnv directory from VSIX package.
    • Addresses issue with vsce failing due to symlinks in .direnv.
  • Misc:
    • Suggests considering a whitelist strategy for packaging instead of a blacklist.

This description was created by Ellipsis for ac0ffee. It will automatically update as commits are pushed.

If somebody uses direnv tool, the `.direnv` directory is created,
that contains some data and especially some symlinks.
Symlinks makes `vsce` to fail zipping the built VSIX.

Generally `.direnv` should not be added to the resulting VSIX,
therefore I add it to .vscodeignore.
@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: ac0ffee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Apr 10, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I see your point, but I'm nervous about the whitelist approach leading to problems where something works locally but we forget to add to this file and the marketplace build doesn't work...

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2025
@mrubens mrubens merged commit 0ddfa4d into RooCodeInc:main Apr 10, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants