Skip to content

Conversation

@zhangtony239
Copy link
Contributor

@zhangtony239 zhangtony239 commented Apr 10, 2025

Context

Fixed the abnormality of setting comment display under Simplified Chinese.

Something unexpected

During husky, it showed that there are some err:

src/exports/ipc.ts:5:17 - error TS2307: Cannot find module 'node-ipc' or its corresponding type declarations.

5 import ipc from "node-ipc"
                  ~~~~~~~~~~

src/exports/ipc.ts:41:30 - error TS7006: Parameter 'socket' implicitly has an 'any' type.

41    ipc.server.on("connect", (socket) => this.onConnect(socket))
                                ~~~~~~

src/exports/ipc.ts:42:42 - error TS7006: Parameter 'socket' implicitly has an 'any' type.

42    ipc.server.on("socket.disconnected", (socket) => this.onDisconnect(socket))
                                            ~~~~~~

src/exports/ipc.ts:43:30 - error TS7006: Parameter 'data' implicitly has an 'any' type.

43    ipc.server.on("message", (data) => this.onMessage(data))
                                ~~~~


Found 4 errors in the same file, starting at: src/exports/ipc.ts:5

husky - pre-push script failed (code 2)
error: failed to push some refs to 'https://github.com/zhangtony239/Roo-Code.git'
PS C:\repos\Roo-Code> git push origin zhangtony239 --force   

> [email protected] compile
> tsc -p . --outDir out && node esbuild.js

src/exports/ipc.ts:5:17 - error TS2307: Cannot find module 'node-ipc' or its corresponding type declarations.

5 import ipc from "node-ipc"
                  ~~~~~~~~~~

src/exports/ipc.ts:41:30 - error TS7006: Parameter 'socket' implicitly has an 'any' type.

41    ipc.server.on("connect", (socket) => this.onConnect(socket))
                                ~~~~~~

src/exports/ipc.ts:42:42 - error TS7006: Parameter 'socket' implicitly has an 'any' type.

42    ipc.server.on("socket.disconnected", (socket) => this.onDisconnect(socket))
                                            ~~~~~~

src/exports/ipc.ts:43:30 - error TS7006: Parameter 'data' implicitly has an 'any' type.

43    ipc.server.on("message", (data) => this.onMessage(data))
                                ~~~~


Found 4 errors in the same file, starting at: src/exports/ipc.ts:5

husky - pre-push script failed (code 2)
error: failed to push some refs to 'https://github.com/zhangtony239/Roo-Code.git'

I have skipped this checks as they might not relevant to this PR.

Screenshots

before after
image image

How to Test

  • F5 run the code
  • open Settings button
  • language set to 简体中文 (zh-CN)
  • you will find what the Screenshots part showed

Get in Touch

discord: zhangtony239


Important

Fixes CSS issue in Chinese i18n settings by adjusting text display for line breaks in ApiOptions.tsx and zh-CN/settings.json.

  • CSS Fix:
    • In ApiOptions.tsx, added whiteSpace: "pre-line" to the CSS style of the description text to handle line breaks correctly.
    • Updated zh-CN/settings.json to replace <br> with \n for line breaks in the customModel.capabilities text.
  • Misc:
    • TypeScript errors in ipc.ts were encountered but not addressed in this PR.

This description was created by Ellipsis for 48a2fd6. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: 93fac05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 10, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Btw I think think npm run install:all will fix your issue with libraries.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 10, 2025
@mrubens mrubens merged commit 255a158 into RooCodeInc:main Apr 10, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants