fix: AWS credentials caching issue #2471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RooCodeInc#2469 Add logic to refresh AWS credentials when they expire. * **src/api/providers/bedrock.ts** - Add logic to refresh AWS credentials using `fromIni` from `@aws-sdk/credential-providers` when a request fails due to expired credentials. - Update `createMessage` and `completePrompt` methods to handle credential refresh. - Add a private method `refreshCredentials` to handle the actual credential refresh process. * **src/api/providers/__tests__/bedrock.test.ts** - Add tests to verify that refreshed credentials are automatically detected and used without requiring a restart. * **src/api/providers/__tests__/bedrock-invokedModelId.test.ts** - Add tests for detecting and using refreshed credentials. * **src/api/providers/__tests__/bedrock-custom-arn.test.ts** - Add tests for detecting and using refreshed credentials. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/RooVetGit/Roo-Code/issues/2469?shareId=XXXX-XXXX-XXXX-XXXX).
|
dwin
changed the title
…Client instances with refreshed credentials
Collaborator
|
Thank you for reporting the issue and opening a PR! Let me know when it's ready for review 🙏 |
Collaborator
|
Did #2530 fix this for you in 3.11.15? |
Collaborator
|
Going to close this for now but let me know if that was premature. Thank you for digging in! |
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2469
Add logic to refresh AWS credentials when they expire.
src/api/providers/bedrock.ts
fromInifrom@aws-sdk/credential-providerswhen a request fails due to expired credentials.createMessageandcompletePromptmethods to handle credential refresh.refreshCredentialsto handle the actual credential refresh process.src/api/providers/tests/bedrock.test.ts
src/api/providers/tests/bedrock-invokedModelId.test.ts
src/api/providers/tests/bedrock-custom-arn.test.ts
For more details, open the Copilot Workspace session.