Fix discard changes in settings

[mrubens]

#2477, broke in #2355

---

Important

Fixes tab switching behavior in App.tsx for SettingsView to correctly set tab to "chat" on completion.

• Behavior:
  • Fixes tab switching behavior in App.tsx by changing onDone callback in SettingsView from switchTab("chat") to setTab("chat").
• Misc:
  • Addresses issue Discard Changes option not working when leaving settings pane #2477 related to discarding changes in settings.

^{This description was created by for a195b59. It will automatically update as commits are pushed.}

[changeset-bot]

⚠️ No Changeset found

Latest commit: a195b59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ellipsis-dev]

The onDone callback for SettingsView now directly calls setTab('chat') instead of using switchTab('chat'). This bypasses the unsaved changes check (settingsRef.current.checkUnsaveChanges) that was previously handled by switchTab. Ensure that this intended change is acceptable for our discard changes behavior.

Suggested change

	<SettingsView ref={settingsRef} onDone={() => setTab("chat")} targetSection={currentSection} />
	<SettingsView ref={settingsRef} onDone={() => switchTab("chat")} targetSection={currentSection} />

[mrubens]

That's the point

[hannesrudolph]

Thank you