Skip to content

Conversation

@sachasayan
Copy link
Contributor

@sachasayan sachasayan commented Apr 11, 2025

Context

Screenshot 2025-04-11 at 1 51 12 AM

Screenshot 2025-04-11 at 2 40 12 AM

Implementation

Switch from checkboxes to VSCodeButtons. Custom styling for big touch targets and active/inactive indications.

Tooltips replace the old long-descriptions for a more compact look.

Screenshots

buttons.mov

How to Test

Open the panel, click away. :)

This also replaces the similar panel in the settings pane:

Screenshot 2025-04-11 at 2 37 03 AM


Important

Replaced checkboxes with buttons in AutoApproveMenu.tsx and AutoApproveSettings.tsx, updated tooltips, and revised translations for a more compact and consistent UI.

  • UI Changes:
    • Replaced VSCodeCheckbox with VSCodeButton in AutoApproveMenu.tsx and AutoApproveSettings.tsx for better touch targets and active/inactive states.
    • Updated layout to a grid format for buttons in AutoApproveMenu.tsx and AutoApproveSettings.tsx.
  • Tooltips:
    • Added tooltips to buttons for compact descriptions in AutoApproveMenu.tsx and AutoApproveSettings.tsx.
  • Translations:
    • Updated labels in settings.json for Catalan, German, English, and Spanish to reflect new button labels and descriptions.

This description was created by Ellipsis for 348effef3ee213cda371bb2d347cf93914cf87bc. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 16a0d9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 11, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the iconMap declaration outside the map callback so that it's not recreated on every render. This improves performance and keeps the render method cleaner.

@samhvw8
Copy link
Contributor

samhvw8 commented Apr 11, 2025

cool

@sachasayan
Copy link
Contributor Author

More changes incoming on this one with feedback. ^_^

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 12, 2025
@sachasayan
Copy link
Contributor Author

Screenshot 2025-04-11 at 12 13 23 PM

Uploading Screenshot 2025-04-12 at 4.22.12 PM.png…

Screen.Recording.2025-04-11.at.1.48.22.PM.mov
  • New Boomerangs label + icons.
  • Additional translations.
  • Improved scaling.
  • Sub-settings on toggle in Settings pane.
  • All tests passing.

@mrubens @hannesrudolph

Ready to go. :shipit:

@heyseth
Copy link
Contributor

heyseth commented Apr 12, 2025

Looks really nice! I personally think the label for "Boomerangs" should read "Subtasks" as that wording is more intuitive to me.

@sachasayan
Copy link
Contributor Author

Looks really nice! I personally think the label for "Boomerangs" should read "Subtasks" as that wording is more intuitive to me.

@heyseth I agree, personally. I might have misunderstood @hannesrudolph but I believe the request (see above) was for subtasks to reflect the current branding direction and be called "Boomerangs", however, since all the marketing materials are referring to them as such.

@sachasayan sachasayan force-pushed the feature/approve-grid-toggles branch 3 times, most recently from 1391169 to 7a6ad5b Compare April 12, 2025 22:46
@sachasayan
Copy link
Contributor Author

Verbiage changed back to "Subtasks" as per discussion in Discord.

:shipit:

Button grid layout. Consolidates shortNames and labels, includes translations.
@sachasayan sachasayan force-pushed the feature/approve-grid-toggles branch from 7a6ad5b to 16a0d9e Compare April 12, 2025 22:58
@hannesrudolph
Copy link
Collaborator

this looks great! The only thing I think we might have lost is the information blurbs with each checkbox we had before. Any ideas on how we can incoporate this without getting up in peoples face? I like the buttons because I know what they do. Some people newer might not.

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 14, 2025
@sachasayan
Copy link
Contributor Author

this looks great! The only thing I think we might have lost is the information blurbs with each checkbox we had before. Any ideas on how we can incorporate this without getting up in peoples face? I like the buttons because I know what they do. Some people newer might not.

They're still in the tooltips! Mouse over and you get the same helpful blurb as before. :)

@cte
Copy link
Collaborator

cte commented Apr 15, 2025

This is awesome - thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2025
@cte cte merged commit 111ac9c into RooCodeInc:main Apr 15, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants