Skip to content

Conversation

@dooezgo
Copy link

@dooezgo dooezgo commented Apr 11, 2025

Context

update the condition to detect the Databrick Azure provider in OpenAI Compatible provider config to make it stream the response.
WHY: The stream option does not work for the Databricks model
image

Implementation

Based on #2449 , add condition isDatabricksAI

Screenshots

before after

How to Test

Configure Databricks Azure API endpoint in the Open AI Compatible provider and enable streaming support.
After the fix streaming works with models are provided by Databricks can stream as expected.
I didn't try on Databrick instance on AWS.

Get in Touch


Important

Add support for streaming Databricks models in OpenAI Compatible provider by excluding stream_options for Databricks AI.

  • Behavior:
    • Update OpenAiHandler in openai.ts to support streaming for Databricks models by excluding stream_options when isDatabricksAI is true.
    • Introduce _isDatabricksAI() method to detect Databricks AI based on openAiBaseUrl.
  • Tests:
    • Add tests in openai.test.ts to verify Databricks AI configuration and ensure stream_options is excluded during streaming.
    • Test cases include initialization and streaming behavior for Databricks AI.

This description was created by Ellipsis for e05d7696193a1833d10c11898d328c7d7dbe5bd8. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: abcf613

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Apr 11, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider extracting the (isGrokXAI || isDatabricksAI) check into a helper function for clarity and maintainability if similar conditions are repeated in the future.

@samhvw8
Copy link
Contributor

samhvw8 commented Apr 11, 2025

Should we make azure profiler for this ?

@dooezgo dooezgo force-pushed the databricks-openai-streaming branch from e05d769 to 784bded Compare April 11, 2025 16:15
@dooezgo dooezgo force-pushed the databricks-openai-streaming branch from 7d086fe to abcf613 Compare April 11, 2025 16:55
@dooezgo
Copy link
Author

dooezgo commented Apr 11, 2025

Should we make azure profiler for this ?

@samhvw8 Databricks is hosted on multiple cloud platforms. They have the same API usage. So I don't think we need to create the Azure profiler for it. How do you think?

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 14, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* Added Sambanova Deepseek-V3-0324

* Added changeset
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Needs Review] in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

Thanks for your contribution. We genuinely apologize the delay on reviewing your PR.

We're closing this PR because we'd prefer have an issue for this since we now shifted to a clearer issue-first workflow to avoid this kind of situation going forward. Please open a new issue if you'd like to revisit this PR.

We truly appreciate your patience and would be happy to have you continue contributing.

@daniel-lxs daniel-lxs closed this May 27, 2025
@github-project-automation github-project-automation bot moved this from Needs Preliminary Review to Done in Roo Code Roadmap May 27, 2025
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants