Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Apr 12, 2025

#2508


Important

readFileTool now respects maxReadFileLine of -1 to read the full file, with updated tests to verify behavior.

  • Behavior:
    • readFileTool in readFileTool.ts now respects maxReadFileLine setting of -1 to read the full file, ignoring range parameters.
    • No line snippet shown in approval message when maxReadFileLine is -1.
  • Tests:
    • Added tests in read-file-maxReadFileLine.test.ts for maxReadFileLine set to -1, ensuring full file read and ignoring range parameters.
    • Verified no line snippet in approval message for full file read.
  • Misc:
    • Added changeset file tough-coats-hear.md to document the patch.

This description was created by Ellipsis for a2b06a7. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

🦋 Changeset detected

Latest commit: a2b06a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 12, 2025
@mrubens mrubens force-pushed the respect_always_full_read_setting branch from c15fc42 to a2b06a7 Compare April 12, 2025 04:14
@mrubens mrubens merged commit 624691a into main Apr 12, 2025
9 checks passed
@mrubens mrubens deleted the respect_always_full_read_setting branch April 12, 2025 04:14
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 12, 2025
JorkeyLiu pushed a commit to JorkeyLiu/Roo-Code that referenced this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants