Skip to content

Conversation

@bogdan0083
Copy link
Contributor

@bogdan0083 bogdan0083 commented Apr 12, 2025

Context

I'm fixing the Node.js version format in the .tool-versions file by removing the 'v' prefix. This is needed because asdf doesn't recognize Node.js versions with the 'v' prefix, which was preventing npm install from working properly.

Implementation

The fix was super simple - just removed the 'v' prefix from the Node.js version in the .tool-versions file:

Before:

nodejs v20.18.1

After:

nodejs 20.18.1

Note that the .nvmrc file still has v20.18.1 with the 'v' prefix, which is correct for nvm. Only the .tool-versions file needed the update for asdf compatibility.

How to Test

  1. Check out this branch: fix/tool-versions-nodejs-format
  2. Run asdf install nodejs 20.18.1 (should work without errors)
  3. Run npm install (should work without errors)
  4. Verify that the development setup works by following the steps in SETUP_DEV.md

Get in Touch

I'm on the Roo Discord as @bgdn2608

Thanks guys! ❤️


Important

Remove 'v' prefix from Node.js version in .tool-versions for asdf compatibility.

  • Behavior:
    • Removed 'v' prefix from Node.js version in .tool-versions for asdf compatibility.
    • .nvmrc file remains unchanged with 'v' prefix for nvm compatibility.

This description was created by Ellipsis for cbe3a71. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

⚠️ No Changeset found

Latest commit: cbe3a71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 12, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 12, 2025

@cte were you saying that it only works for you if you have the v?

@cte
Copy link
Collaborator

cte commented Apr 12, 2025

@cte were you saying that it only works for you if you have the v?

I was seeing warnings related to the lack of the v prefix, but I can take another look.

@bogdan0083
Copy link
Contributor Author

With v prefix I have this error when trying to access node or npm:

Roo-Code % node --version
No preset version installed for command node
Please install a version by running one of the following:

asdf install nodejs v20.18.1

And suggested command doesn't work:

~ % asdf install nodejs v20.18.1
Trying to update node-build... ok
node-build: definition not found: v20.18.1

Removing 'v' prefix fixes the issue for me.

@bogdan0083
Copy link
Contributor Author

My asdf version is v0.13.1, just in case.

@cte
Copy link
Collaborator

cte commented Apr 12, 2025

Looks like it was an issue local to me - omitting the 'v' is the correct thing to do.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 12, 2025
@cte cte merged commit c25163a into RooCodeInc:main Apr 12, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants