-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Evals enhancements: delete runs, show all run instead of just completed runs #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The pull request includes a variety of changes, such as updating dependencies, adding new UI components, and implementing server-side functionality for deleting runs. While these changes seem to be related to enhancing the evaluation runs feature, the pull request is quite extensive with 9 changed files and 791 lines added. To facilitate easier review and ensure each change is thoroughly examined, it might be beneficial to split this pull request into smaller, more focused pull requests. For instance, consider separating the UI component additions from the server-side functionality changes. This way, reviewers can focus on specific aspects of the feature enhancement, leading to more effective feedback and a smoother review process. Please consider splitting the pull request accordingly. Thank you! |
* refactor types and functions * fix timeout validation type error * changeset * connect to SSE MCP servers * remove old changeset * changeset
Context
Implementation
Screenshots
How to Test
Get in Touch
Important
Enhance evals by adding run deletion and displaying all runs, with new UI components for alert dialogs and dropdown menus.
deleteRuninruns.tsandqueries/runs.ts.Homecomponent inhome.tsxto show all runs, not just completed ones.AlertDialoginhome.tsx.alert-dialog.tsxfor alert dialog UI components.dropdown-menu.tsxfor dropdown menu UI components.index.tsto export new UI components.package.jsonto include@radix-ui/react-alert-dialogand@radix-ui/react-dropdown-menu.This description was created by
for 1c72503. It will automatically update as commits are pushed.