Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Apr 12, 2025

Context

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Enhance evals by adding run deletion and displaying all runs, with new UI components for alert dialogs and dropdown menus.

  • Behavior:
    • Adds ability to delete runs using deleteRun in runs.ts and queries/runs.ts.
    • Modifies Home component in home.tsx to show all runs, not just completed ones.
    • Implements confirmation dialog for run deletion using AlertDialog in home.tsx.
  • UI Components:
    • Adds alert-dialog.tsx for alert dialog UI components.
    • Adds dropdown-menu.tsx for dropdown menu UI components.
    • Updates index.ts to export new UI components.
  • Dependencies:
    • Updates package.json to include @radix-ui/react-alert-dialog and @radix-ui/react-dropdown-menu.

This description was created by Ellipsis for 1c72503. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

⚠️ No Changeset found

Latest commit: 1c72503

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 12, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Apr 12, 2025

The pull request includes a variety of changes, such as updating dependencies, adding new UI components, and implementing server-side functionality for deleting runs. While these changes seem to be related to enhancing the evaluation runs feature, the pull request is quite extensive with 9 changed files and 791 lines added.

To facilitate easier review and ensure each change is thoroughly examined, it might be beneficial to split this pull request into smaller, more focused pull requests. For instance, consider separating the UI component additions from the server-side functionality changes. This way, reviewers can focus on specific aspects of the feature enhancement, leading to more effective feedback and a smoother review process.

Please consider splitting the pull request accordingly. Thank you!

@cte cte merged commit 9117862 into main Apr 12, 2025
15 checks passed
@cte cte deleted the cte/more-evals-fixes branch April 12, 2025 07:07
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 12, 2025
@dosubot dosubot bot added the enhancement New feature or request label Apr 12, 2025
JorkeyLiu pushed a commit to JorkeyLiu/Roo-Code that referenced this pull request Apr 13, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* refactor types and functions

* fix timeout validation type error

* changeset

* connect to SSE MCP servers

* remove old changeset

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants