Skip to content

Fix/remove path lib webview #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Fix/remove path lib webview #2529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2f4b3
Refactor: Replace path.basename with custom getBasename function for …
samhvw8 Apr 13, 2025
d5922fe
refactor: Replace path.basename with custom getBasename function for …
samhvw8 May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions webview-ui/src/utils/context-mentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
import { mentionRegex } from "@roo/shared/context-mentions"
import { Fzf } from "fzf"
import { ModeConfig } from "@roo/shared/modes"
import * as path from "path"

import { escapeSpaces } from "./path-mentions"

export interface SearchResult {
path: string
type: "file" | "folder"
label?: string
}

function getBasename(filepath: string): string {
return filepath.split("/").pop() || filepath
}

export function insertMention(
text: string,
position: number,
Expand Down Expand Up @@ -254,7 +259,7 @@ export function getContextMenuOptions(

// For display purposes, we don't escape spaces in the label or description
const displayPath = formattedPath
const displayName = result.label || path.basename(result.path)
const displayName = result.label || getBasename(result.path)

// We don't need to escape spaces here because the insertMention function
// will handle that when the user selects a suggestion
Expand Down
Loading