Skip to content

Conversation

@vagadiya
Copy link
Contributor

@vagadiya vagadiya commented Apr 12, 2025

Context

Updates the Bedrock ARN regex to allow alphanumeric characters, dots, hyphens, and colons in the resource ID.

This prevents validation errors when using ARNs containing those characters.

Implementation

Change to the regex used

Screenshots

image

How to Test

Input an ARN such as

arn:aws:bedrock:us-east-1:696926768285:application-inference-profile/7f6boiz8ouih

Get in Touch

vagadiya


Important

Update Bedrock ARN regex to allow more characters in resource ID, preventing validation errors.

  • Regex Update:
    • In bedrock.ts and validate.ts, updated ARN regex to allow alphanumeric characters, dots, hyphens, and colons in the resource ID.
  • Behavior:
    • Prevents validation errors for ARNs with these characters in AwsBedrockHandler and validateBedrockArn().

This description was created by Ellipsis for ab770f1. It will automatically update as commits are pushed.

Updates the Bedrock ARN regex to allow alphanumeric characters, dots, hyphens, and colons in the resource ID.

This prevents validation errors when using ARNs containing those characters.
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

⚠️ No Changeset found

Latest commit: ab770f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 12, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 12, 2025
@mrubens mrubens merged commit 294b52e into RooCodeInc:main Apr 12, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 12, 2025
@vagadiya vagadiya deleted the fix_for_aws_custom_arn_validation branch April 13, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants