-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feature: Closable welcome message #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I see it's still in draft - is it ready to be merged? Thank you for the contribution.
|
@zhangtony239 @mrubens should we use state in webview-ui/src/utils/vscode.ts for reduce provider state, this state is webview state and it's persistent too and using this state, we can reduce the code change ? |
I agree we should think more about our state management and how it's gotten to be so complicated / whether we should do things differently, but I don't think we should try to address that in this PR. |
yeah, let make that in another pr |
Wow, really? I think there is a test action did not pass well, a little afraid to pr. |
Context
Make Roo's welcome message can be turned off, not only to get a cleaner interface, but also to provide enough space for more possibilities for the future homepage.
Also, the
interfacecategory of this setting provides a suitable location for subsequent interface component switches.I18n warning
I executed i18n entirely using Roo's translation mode, and my personal language skills are not sufficient for manual proofreading, so please assist in checking!
Screenshots
How to Test
By the way
I wanted to mention that the
settings.mdcurrently located in cline_docs is really a bit skimpy. It took me a whole day of debugging with Gemini-2.5-pro-exp on Roo to familiarize myself with the roo project structure by this pr. Or maybe it's just because I'm still learning TypeScript foundation …Get in Touch
Discord: zhangtony239
Important
Adds a feature to toggle the welcome message in Roo, with updates to settings, UI components, and translations.
InterfaceSettings.tsxandSettingsView.tsx.ClineProvider.tsto includeshowGreetingin the state.webviewMessageHandler.tsto handleshowGreetingmessages.ChatView.tsxto conditionally render the welcome message based onshowGreeting.InterfaceSettings.tsxfor managing interface-related settings.settings.jsonfor various locales.ExtensionStateContext.tsxto manageshowGreetingstate.showGreetingtoGlobalSettingsintypes.tsandroo-code.d.ts.This description was created by
for 0cd6d60. It will automatically update as commits are pushed.