Skip to content

Conversation

@zhangtony239
Copy link
Contributor

@zhangtony239 zhangtony239 commented Apr 12, 2025

Context

Make Roo's welcome message can be turned off, not only to get a cleaner interface, but also to provide enough space for more possibilities for the future homepage.

Also, the interface category of this setting provides a suitable location for subsequent interface component switches.

I18n warning

I executed i18n entirely using Roo's translation mode, and my personal language skills are not sufficient for manual proofreading, so please assist in checking!

Screenshots

before after
image image

How to Test

  • Run this code
  • Find Interface in settings and uncheck Show greeting message.
  • Save, done, back to Roo home page
  • You'll notice that the Title is gone, as shown in the screenshots above.

By the way

I wanted to mention that the settings.md currently located in cline_docs is really a bit skimpy. It took me a whole day of debugging with Gemini-2.5-pro-exp on Roo to familiarize myself with the roo project structure by this pr. Or maybe it's just because I'm still learning TypeScript foundation …

Get in Touch

Discord: zhangtony239


Important

Adds a feature to toggle the welcome message in Roo, with updates to settings, UI components, and translations.

  • Behavior:
    • Adds a toggle for the welcome message in InterfaceSettings.tsx and SettingsView.tsx.
    • Default behavior is to show the welcome message unless disabled in settings.
  • State Management:
    • Updates ClineProvider.ts to include showGreeting in the state.
    • Modifies webviewMessageHandler.ts to handle showGreeting messages.
  • UI Components:
    • Updates ChatView.tsx to conditionally render the welcome message based on showGreeting.
    • Adds InterfaceSettings.tsx for managing interface-related settings.
  • Internationalization:
    • Adds translations for the new setting in multiple language files, including settings.json for various locales.
  • Misc:
    • Updates ExtensionStateContext.tsx to manage showGreeting state.
    • Adds showGreeting to GlobalSettings in types.ts and roo-code.d.ts.

This description was created by Ellipsis for 0cd6d60. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

⚠️ No Changeset found

Latest commit: 0cd6d60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 12, 2025
@zhangtony239 zhangtony239 marked this pull request as draft April 13, 2025 00:44
@zhangtony239 zhangtony239 marked this pull request as ready for review April 13, 2025 00:45
@zhangtony239 zhangtony239 marked this pull request as draft April 13, 2025 00:45
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I see it's still in draft - is it ready to be merged? Thank you for the contribution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2025
@samhvw8
Copy link
Contributor

samhvw8 commented Apr 13, 2025

@zhangtony239 @mrubens should we use state in webview-ui/src/utils/vscode.ts for reduce provider state, this state is webview state and it's persistent too

and using this state, we can reduce the code change ?

@mrubens
Copy link
Collaborator

mrubens commented Apr 13, 2025

@zhangtony239 @mrubens should we use state in webview-ui/src/utils/vscode.ts for reduce provider state, this state is webview state and it's persistent too

and using this state, we can reduce the code change ?

I agree we should think more about our state management and how it's gotten to be so complicated / whether we should do things differently, but I don't think we should try to address that in this PR.

@samhvw8
Copy link
Contributor

samhvw8 commented Apr 13, 2025

@zhangtony239 @mrubens should we use state in webview-ui/src/utils/vscode.ts for reduce provider state, this state is webview state and it's persistent too
and using this state, we can reduce the code change ?

I agree we should think more about our state management and how it's gotten to be so complicated / whether we should do things differently, but I don't think we should try to address that in this PR.

yeah, let make that in another pr

@zhangtony239
Copy link
Contributor Author

Looks good to me! I see it's still in draft - is it ready to be merged? Thank you for the contribution.

Wow, really? I think there is a test action did not pass well, a little afraid to pr.
Is it too late for me to resume pr?

@zhangtony239 zhangtony239 marked this pull request as ready for review April 13, 2025 04:48
@mrubens mrubens merged commit d3c65ce into RooCodeInc:main Apr 13, 2025
40 of 41 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants