Skip to content

Conversation

@nobu007
Copy link
Contributor

@nobu007 nobu007 commented Apr 12, 2025

Context

--ext is removed.

Implementation

Screenshots

How to Test

  • before
[lint         ] [lint:e2e      ] > eslint src --ext ts
[lint         ] [lint:e2e      ] 
[check-types  ] [check-types:webview  ] 
[check-types  ] [check-types:webview  ] > [email protected] check-types
[check-types  ] [check-types:webview  ] > tsc
[check-types  ] [check-types:webview  ] 
[lint         ] ERROR: "lint:extension" exited with 2.
ERROR: "lint" exited with 1.
 ERROR  npm failed with exit code 1
jinno@jinno-desktop:~/GuiAgentLoopCoreXtract/Roo-Code-Auto  (main *) $ npm --version
10.2.4
jinno@jinno-desktop:~/GuiAgentLoopCoreXtract/Roo-Code-Auto  (main *) $ npm run lint:version

> [email protected] lint:version
> eslint --version

v8.57.1
  • after
[lint         ] [lint:e2e      ] /home/jinno/GuiAgentLoopCoreXtract/Roo-Code-Auto/e2e/src/suite/utils.ts
[lint         ] [lint:e2e      ]   0:0  warning  File ignored because of a matching ignore pattern. Use "--no-ignore" to disable file ignore settings or use "--no-warn-ignored" to suppress this warning
[lint         ] [lint:e2e      ] 
[lint         ] [lint:e2e      ] ✖ 6 problems (0 errors, 6 warnings)

btw, warning is ok?

Get in Touch

eslint/eslint#17931
https://eslint.org/docs/latest/use/configure/migration-guide#cli-flag-changes


Important

Remove --ext option from ESLint commands in multiple package.json files, replacing it with glob patterns for file extensions.

  • Behavior:
    • Remove --ext option from ESLint commands in e2e/package.json, evals/apps/cli/package.json, and evals/packages/db/package.json.
    • Replace with glob pattern src/**/*.ts or src/**/*.ts src/**/*.tsx to specify file extensions.
  • Files Affected:
    • e2e/package.json: Change "lint": "eslint src --ext ts" to "lint": "eslint src/**/*.ts".
    • evals/apps/cli/package.json: Change "lint": "eslint src --ext ts --max-warnings=0" to "lint": "eslint src/**/*.ts --max-warnings=0".
    • webview-ui/package.json: Change "lint": "eslint src --ext ts,tsx" to "lint": "eslint src/**/*.ts src/**/*.tsx".
  • Misc:
    • Update package.json and other package.json files similarly to ensure consistent linting across the project.

This description was created by Ellipsis for 65d0784881220b41dd2bcb9407a4481aedc3ddf6. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2025

⚠️ No Changeset found

Latest commit: af9351f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nobu007 nobu007 force-pushed the fix_eslint_ext branch 2 times, most recently from c52571b to 65d0784 Compare April 12, 2025 19:02
@nobu007 nobu007 changed the title chore: remove --ext option from eslint Fix eslint error about --ext option by remove it Apr 12, 2025
@nobu007 nobu007 marked this pull request as ready for review April 12, 2025 19:05
@nobu007 nobu007 requested review from cte and mrubens as code owners April 12, 2025 19:05
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 12, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'lint-fix' script, the glob for TSX files is 'src//*tsx' while the 'lint' script uses 'src//.tsx'. For consistency and to avoid missing files, consider using the same glob pattern (e.g. 'src/**/.tsx') in both scripts.

Suggested change
"lint-fix": "eslint src/**/*.ts src/**/*tsx --fix",
"lint-fix": "eslint src/**/*.ts src/**/*.tsx --fix",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellipsis-dev
I fixed it.

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2025
@cte cte merged commit 30c3a65 into RooCodeInc:main Apr 14, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 14, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants