Skip to content

Conversation

@bramburn
Copy link
Contributor

@bramburn bramburn commented Apr 14, 2025

Context

Continuing from #2494 I just rebuilt it and it seems to work. I can see if there is another error

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Refactor HTML content generation in ClineProvider.ts by moving it to WebviewHTMLManager.ts for better code organization.

  • Refactoring:
    • Moved HTML content generation logic from ClineProvider.ts to WebviewHTMLManager.ts.
    • Removed getHMRHtmlContent and getHtmlContent from ClineProvider.ts.
    • Added WebviewHTMLManager class with getHMRHtmlContent and getHtmlContent methods.
  • Imports:
    • Removed getNonce and getUri imports from ClineProvider.ts.
    • Added WebviewHTMLManager import to ClineProvider.ts.
  • Behavior:
    • ClineProvider now uses WebviewHTMLManager for HTML content generation in resolveWebviewView().

This description was created by Ellipsis for c4807b9. It will automatically update as commits are pushed.

- 【What】Move the logic for generating webview HTML content from ClineProvider to a new WebviewHTMLManager class.
- 【Why】This improves code organization and maintainability by separating concerns related to webview HTML generation.
- 【Why】This allows for easier testing and modification of the HTML generation logic without affecting the ClineProvider class.
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: c4807b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 14, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 14, 2025

I'm still having the same problem

Screenshot 2025-04-14 at 2 29 09 PM

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 14, 2025
@bramburn
Copy link
Contributor Author

bramburn commented Apr 15, 2025 via email

SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

Hey @bramburn,
Thank you for your contribution, We noticed this PR is stale and will be closed. If you plan to revisit this, please create an issue first as required by our issue-first approach before opening a new PR.

@daniel-lxs daniel-lxs closed this May 26, 2025
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap May 26, 2025
@github-project-automation github-project-automation bot moved this from TEMP to Done in Roo Code Roadmap May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants