Skip to content

Conversation

@zhangtony239
Copy link
Contributor

@zhangtony239 zhangtony239 commented Apr 14, 2025

Context

Enable Roo's workspace-related features only when vscode is in workspace mode, in order to reduce visual and usability overhead for users who are not accustomed to using workspaces.

Screenshots

before (workspace enabled) after (workspace disabled)
image image
image image

How to Test

  • Run this code.
  • Switch VS Code’s workspace setting (make sure to save your data first, as this will immediately restart VS Code).
  • Check the Home and History pages. Workspace-related content should no longer be visible when VS Code is not in workspace mode — the UI should resemble how Roo looked before workspace support was added.

Get in Touch

Discord: zhangtony239


Important

Syncs VSCode's workspace trust setting to control workspace-related UI and functionality in the application.

  • Behavior:
    • Syncs workspace.trust.enabled setting from VSCode in ClineProvider.
    • Updates UI in HistoryPreview.tsx and HistoryView.tsx to hide workspace-related content if workspace trust is disabled.
  • State Management:
    • Adds workspaceTrustEnabled to ExtensionState in ExtensionMessage.ts and ExtensionStateContext.tsx.
    • Uses useEffect in HistoryPreview.tsx and HistoryView.tsx to set showAllWorkspaces based on workspaceTrustEnabled.
  • Misc:
    • Updates getStateToPostToWebview() in ClineProvider.ts to include workspaceTrustEnabled.

This description was created by Ellipsis for 7811af4. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 7811af4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Apr 14, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 14, 2025

Thanks @zhangtony239! @samhvw8 mind taking a look at this one to see if it looks ok to you?

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 14, 2025
@samhvw8
Copy link
Contributor

samhvw8 commented Apr 15, 2025

@zhangtony239 @mrubens can we add more information like "History Is Filtered Because Workspace Not Trusted" something like that for UI UX ?

@zhangtony239
Copy link
Contributor Author

Well... as more UI elements are added in the future, it's foreseeable that the Interface section in settings will need a more detailed level of personalization, which allowing users to achieve true visual efficiency in their day-to-day use of Roo. The implementation in this PR should actually be considered part of that — specifically, it's the effect you'd expect when the Workspace toggle is enabled under the auto option.

No doubt this would make Roo way more flexible for different user preferences — but it also means quite a bit of extra work... so, curious to hear your thoughts! @mrubens @samhvw8

@zhangtony239
Copy link
Contributor Author

@zhangtony239 @mrubens can we add more information like "History Is Filtered Because Workspace Not Trusted" something like that for UI UX ?

And this could be added in the description of those settings.

@zhangtony239
Copy link
Contributor Author

Given the limitations in the current implementation and the fact that it's fallen behind the latest changes, I'm closing this PR for now.
I really appreciate the discussion and feedback from everyone — I'll revisit and rework this in a cleaner way when possible.

@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants