Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Apr 14, 2025

Context

If one provider is malformed then let's not completely fail to parse the entire object.

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

ProviderSettingsManager now parses providers individually, filtering out invalid ones to prevent load failures.

  • Behavior:
    • load() in ProviderSettingsManager.ts now parses providers individually, filtering out invalid ones.
    • Invalid provider configurations do not cause the entire load process to fail.
  • Tests:
    • Added test should remove invalid profiles during load in ProviderSettingsManager.test.ts to verify invalid profiles are filtered out.
  • Misc:
    • Removed unnecessary console logs in migrateRateLimitSeconds() in ProviderSettingsManager.ts.

This description was created by Ellipsis for 13c00ef. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 13c00ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 14, 2025
@dosubot dosubot bot added the enhancement New feature or request label Apr 14, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 14, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 14, 2025
@cte cte merged commit 6f8f8c6 into main Apr 14, 2025
16 checks passed
@cte cte deleted the cte/better-provider-settings-validation branch April 14, 2025 21:51
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants