-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Make Roo Code respect the workbench.fontAliasing setting in VSCode #2612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Hey, I was right about the "arcane interaction" bit! :-) |
Absolutely, thanks for that! 👍 |
* Add remote server form * changeset * naming
|
Just skimming through the code here: Is |
I thought it would too, I tried that first but it does not change the webview aliasing when changing the vscode setting. |
|
Thanks for your contribution. We genuinely apologize for the delay in reviewing your PR. We've now shifted to a clearer issue-first workflow. Please create an issue if you wish to revisit this PR. We appreciate your patience and would be happy to have you continue contributing. |
Context
I made a PR earlier to add a Font aliasing toggle in VScode settings, but it turns out the problem was Roo Code was not respecting the
workbench.fontAliasingsetting from VS Code. This resulted in inconsistent font rendering within the webview compared to the rest of the editor, especially noticeable on macOS. The webview's font anti-aliasing should now match the user's preference set in VS Code.This fix should be more effective.
Implementation
To handle font aliasing properly, I did the following:
This allows the webview to use the font aliasing setting from VS Code.
Important
The PR updates Roo Code to respect the
workbench.fontAliasingsetting from VS Code, ensuring consistent font rendering in the webview.workbench.fontAliasingsetting from VS Code for consistent font rendering.ClineProvider.tsreadsfontAliasingsetting and sends it to the webview.fontAliasingchanges.ClineProvider.ts, added logic to read and sendfontAliasingsetting to webview.ExtensionMessage.ts, addedfontAliasingmessage type with optionalvalue.App.tsx, updatedonMessagehandler to applyfontAliasingto-webkit-font-smoothing.-webkit-font-smoothingtoinheritinindex.css.This description was created by
for 53b9222. It will automatically update as commits are pushed.