Skip to content

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Apr 15, 2025

Context

Follow #2627
Fix double scrollbar

Implementation

Screenshots

before after
image

How to Test

Get in Touch


Important

Enhance SelectDropdown with fuzzy search, Popover integration, and internationalized search placeholder.

  • Behavior:
    • SelectDropdown in select-dropdown.tsx now supports fuzzy search using Fzf.
    • Replaces DropdownMenu with Popover for dropdown rendering.
    • Adds search input with clear functionality in dropdown.
  • Tests:
    • Updates select-dropdown.test.tsx to mock Popover components and test new dropdown behavior.
    • Adds tests for separator, shortcut, and action options.
  • Internationalization:
    • Adds search_placeholder key to common.json in multiple locales for search input placeholder text.

This description was created by Ellipsis for 3f5891f. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025

⚠️ No Changeset found

Latest commit: 6cb0bbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 15, 2025
@adamhill
Copy link
Contributor

Can we add the a11y suggestion from ellipsis for aria-label?

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 15, 2025
@mrubens mrubens merged commit 84c574c into RooCodeInc:main Apr 15, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants