Skip to content

Await checkpoint saves (except the initial) #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2025
Merged

Await checkpoint saves (except the initial) #2665

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9126423
Await checkpoint saves (except the initial)
cte Apr 15, 2025
3eebfb4
Thank you Ellipsis
cte Apr 15, 2025
1a7fa65
More fixes
cte Apr 15, 2025
97202bd
Fix tests by mocking rg
cte Apr 15, 2025
691b5b4
Revert this
cte Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/core/Cline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,9 +1680,11 @@ export class Cline extends EventEmitter<ClineEvents> {
}

const recentlyModifiedFiles = this.fileContextTracker.getAndClearCheckpointPossibleFile()

if (recentlyModifiedFiles.length > 0) {
// TODO: we can track what file changes were made and only checkpoint those files, this will be save storage
this.checkpointSave()
// TODO: We can track what file changes were made and only
// checkpoint those files, this will be save storage.
await this.checkpointSave()
}

/*
Expand Down Expand Up @@ -2508,6 +2510,7 @@ export class Cline extends EventEmitter<ClineEvents> {
},
{ interval, timeout },
)

return service
} catch (err) {
return undefined
Expand Down Expand Up @@ -2569,7 +2572,7 @@ export class Cline extends EventEmitter<ClineEvents> {
}
}

public checkpointSave() {
public async checkpointSave() {
const service = this.getCheckpointService()

if (!service) {
Expand All @@ -2580,14 +2583,15 @@ export class Cline extends EventEmitter<ClineEvents> {
this.providerRef
.deref()
?.log("[checkpointSave] checkpoints didn't initialize in time, disabling checkpoints for this task")

this.enableCheckpoints = false
return
}

telemetryService.captureCheckpointCreated(this.taskId)

// Start the checkpoint process in the background.
service.saveCheckpoint(`Task: ${this.taskId}, Time: ${Date.now()}`).catch((err) => {
return service.saveCheckpoint(`Task: ${this.taskId}, Time: ${Date.now()}`).catch((err) => {
console.error("[Cline#checkpointSave] caught unexpected error, disabling checkpoints", err)
this.enableCheckpoints = false
})
Expand Down