Skip to content

Update openai-format.ts #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update openai-format.ts #2680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/transform/openai-format.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function convertToOpenAiMessages(
}
}
return { type: "text", text: part.text }
}),
}).join("\n") ?? "",
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The mapping of non-tool messages returns objects (e.g. { type: 'image_url', image_url: { url: '...' } } or { type: 'text', text: ... }), but the join function expects an array of strings. Joining these objects will result in undesired '[object Object]' strings. Consider transforming each block to an appropriate string format before joining.

Suggested change
}).join("\n") ?? "",
content: nonToolMessages.map((part) => part.type === "image" ? `data:${part.source.media_type};base64,${part.source.data}` : part.text).join("\n") ?? "",

})
}
} else if (anthropicMessage.role === "assistant") {
Expand Down
Loading