-
Notifications
You must be signed in to change notification settings - Fork 2.6k
refactor(chat): show inline code more subtle #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
This bugs me too! Let's figure out the font size thing though. |
|
I like the font change! One thing that helps me see the code (inline) with normal text is a much more vibrant / saturated color, especially in darker modes. (I have been trained by GH Copilot choices) Are the chat blocks picking up the colors from the theme the user has selected? And would actual large code blocks pick up the theme proper from whatever component we use? |
i guess we need to figure out which token that consistently has bright/stand out colour across colourschemes as for the codeblock, there is some work at #1328 |
|
i played with this a bit more, a few changes:
I think this PR is ready for review. updated preview: BeforeScreen.Recording.2025-05-02.at.00.31.55.movAfterScreen.Recording.2025-05-02.at.00.30.01.mov |
| } | ||
| code:not(pre > code) { | ||
| font-size: 0.9em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be problematic if your VSCode user settings specify a much larger font size.
|
Thanks! |
* new task tool added * small fix * fixed numbering * system prompt
* refactor(chat): show inline code more subtle * refactor: make inline code more readable
Context
I've been wanting to change this for a while. The current inline code feels a bit 'out of place', every time the LLM outputs them I find it hard to read and just clutters the chat.
Implementation
Screenshots
Epilepsy warning, I'm switching between multiple different themes (dark and light) to test it.
Before
Screencast.From.2025-04-18.13-45-17.mp4
After
Screencast.From.2025-04-18.13-45-53.mp4
How to Test
Try having a chat with the LLM and ask it to output some inline code
Get in Touch
@elianiva on Roocode discord server
Important
Refactor inline code styling in
MarkdownBlock.tsxto be more subtle by adjusting font size and border color.MarkdownBlock.tsx, adjustedcode:not(pre > code)to havefont-size: 0.9emfor a slightly smaller appearance.bordercolor ofcode:not(pre > code)tovar(--vscode-tab-border, #424242)for a more subtle look.This description was created by
for 7791b8e. It will automatically update as commits are pushed.