Skip to content

Conversation

@jasonkneen
Copy link

@jasonkneen jasonkneen commented Apr 18, 2025

Context

Those square buttons aren't going to curve themselves -- needed some love.

Implementation

Subtle rounding of buttons and elements, lighting effects for depth.

How to Test

Start, hit the permissions section and just LOOK at those buttons in dark theme mode
Move your mouse over and feel the shimmer go through you

Get in Touch

jasonkneen / [email protected]


Important

Enhance dark theme UI with rounded corners and shimmer effects, and add a fast development script.

  • UI Enhancements:
    • Add rounded corners and lighting effects to vscode-button, vscode-dropdown, vscode-input, and other components in index.css for dark mode.
    • Implement shimmer effect on button hover in index.css.
    • Modify HistoryPreview.tsx to adjust button and text styles.
  • Development:
    • Add dev:fast script in package.json for faster extension development.

This description was created by Ellipsis for b9e7f3a. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: 857c552

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 18, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Apr 18, 2025

The changes in this pull request seem cohesive and related to UI/UX enhancements, specifically focusing on dark theme improvements and styling updates. Therefore, it does not need to be split into smaller pull requests. If you have any questions or need further clarification, feel free to reach out!

@dosubot dosubot bot added the enhancement New feature or request label Apr 18, 2025
@jasonkneen
Copy link
Author

yeh good point

@sachasayan
Copy link
Contributor

Generally speaking, visual flair is always nice.

But I think it might be helpful to take a step back and ask the "what are we trying to achieve?" question with every change: Is it shimmer for the sake of shimmer, or is there a specific goal in mind?

I'm not convinced there's utility value here, and it adds (rather than reduces) visual complexity / tech debt to manage at this time:

Broken Backgrounds

In the settings view, adding a background to the entire body means a lot of weirdness is happening:

Screenshot 2025-04-19 at 5 57 17 PM

Broken primary buttons

The animation doesn't work at all on primary color-accented buttons, and just sits there:

Screenshot 2025-04-19 at 8 13 44 PM

Stylistic incompatibility with light themes means two distinct styles now need to be managed.

Screenshot 2025-04-19 at 8 21 25 PM

Screenshot 2025-04-19 at 8 16 15 PM

Don't make major project changes in small PRs:

Screenshot 2025-04-19 at 8 18 42 PM

Screenshot 2025-04-19 at 8 18 22 PM

@jasonkneen jasonkneen closed this Apr 20, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants