-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add enabledForSwitching config for mode switching control #2795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add enabledForSwitching config to control which modes can be switched to by LLMs - Update system prompts to exclude non-switchable modes from switch_mode tool - Update UI components in PromptsView to include enabledForSwitching checkbox - Update localization files for all supported languages - Update tests to verify behavior with non-switchable modes
|
|
The pull request introduces the 'enabledForSwitching' feature across multiple files, including tests, schemas, and localization files. While the changes are extensive, they appear to be related to a single cohesive feature. However, if there are any unrelated changes or if the changes can be logically grouped into smaller, more manageable pull requests, it might be beneficial to split them up. This can help with easier review and testing. Please consider if any parts of the changes can be separated into distinct pull requests. |
| }, | ||
| "enabledForSwitching": { | ||
| "label": "Habilitar aquest mode per a canvi per IA", | ||
| "description": "Quan està desactivat, aquest mode no s'inclourà al prompt del sistema de la IA i la IA no podrà canviar a aquest mode. Encara podeu seleccionar aquest mode manualment." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the enabledForSwitching block, the description uses 'la IA' (e.g., 'al prompt del sistema de la IA' and 'la IA no podrà canviar a aquest mode'). In Catalan, it should ideally be written as 'l'IA' (e.g., 'al prompt del sistema de l'IA' and 'l'IA no podrà canviar a aquest mode'). This is a minor typographical error, but fixing it will improve clarity.
| "description": "Quan està desactivat, aquest mode no s'inclourà al prompt del sistema de la IA i la IA no podrà canviar a aquest mode. Encara podeu seleccionar aquest mode manualment." | |
| "description": "Quan està desactivat, aquest mode no s'inclourà al prompt del sistema de l'IA i l'IA no podrà canviar a aquest mode. Encara podeu seleccionar aquest mode manualment." |
Add missing Vietnamese translations for enabledForSwitching in prompt…
|
Hey @tychenjiajun, thanks for this! Can you elaborate on what you're trying to achieve here, and how best to test? Are there any unresolved problems or assumptions that you know of? From the description it seems like you're aiming for more granular control over mode switching for each mode itself? Screenshots and video would be appreciated! |
Co-authored-by: Dennis Bartlett <[email protected]>
|
Hi @tychenjiajun, I have a couple of questions regarding mode switching.
The proposed modification to Also, does your current implementation support changing default modes? If not, is this adjustment required? |
|
@tychenjiajun Thanks for submitting this PR, and apologies that it took us so long to review it. We're closing this PR because the related issue wasn't fully scoped yet and is missing some critical aspects, such as completely removing the disabled mode from the system context. Before we can move forward, the issue needs proper scoping and approval. If you'd like, feel free to open a new issue as a Detailed Feature Proposal clearly outlining what changes you propose. This will allow the dev team to properly review, scope, and approve the work. Otherwise, we'll handle the scoping directly within the dev team. We appreciate your contribution and look forward to future input from you! |
Context
Fix #2668
Implementation
Screenshots
How to Test
Get in Touch
Important
Add
enabledForSwitchingconfig to control AI mode switching, update UI, tests, and localization.enabledForSwitchingconfig to control mode switching by AI inmodes.tsandswitchModeTool.ts.getModesSection()inmodes.tsto filter out non-switchable modes.getToolDescriptionsForMode()intools/index.tsto excludeswitch_modetool if no modes are switchable.enabledForSwitchingcheckbox inPromptsView.tsxto toggle mode switching.PromptsView.test.tsxto testenabledForSwitchingbehavior.enabledForSwitchinglabels and descriptions.CustomModesSettings.test.tsto verifyenabledForSwitchingbehavior.modeConfigSchemaandpromptComponentSchemainschemas/index.tsto includeenabledForSwitching.This description was created by
for 2b59d0d. You can customize this summary. It will automatically update as commits are pushed.