-
Notifications
You must be signed in to change notification settings - Fork 2.6k
UI Fixes: History View Refinements #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Draft btw, do not merge. ✌️ |
|
hmm i'm not sure if it's good to remove selection mode and replace it with how it works in this PR, i'm expecting when you click on a task then it will open it clicking while holding shift is more common i think, but to make users discover that without being too ambiguous or add another clutter like "hold shift to select" is something that needs figuring out maybe keep the selection mode but automatically triggers it whenever one of the task is selected? no need to click "selection mode" manually |
|
@elianiva Played around with this last night and tried a checkbox-based variant.... I didn't like it as much. Click target is too small, and/or you end up taking up more horizontal space. Gave it an honest shot, but the vibes weren't there. I'll push another commit in a bit (gotta fix some tests) but as a preview of what I've done to address some of the concerns:
|
94a48df to
5fedaeb
Compare
* initial * added debounce for checkmark expanded ui * corrected bookmark size * removed unnecesary cleanup * fixed removed code * removed cleanup for real this time * refactored to reduce complexity, added cleanup
Truncate workspace names. History misc improvements. Testing.
89dcf6e to
77a2ae6
Compare
|
This one's still here, ready to go. |
|
For what it's worth my intuition is also that clicking on the history row should take you to the task, similar to how it works in the history preview. |
|
I think the rest of these changes are good, would just vote to bring back the selection as a secondary action instead of the primary action. |
|
I'll close this PR as stale, if someone else wants to work on this they can open a new PR. |
Context
useTaskSearchwas upgraded to expand filtering capabilities.Video
Screen.Recording.2025-04-20.at.11.48.17.PM.mov
Get in Touch
As always, InElement on Discord.
Important
Refined History View UI with improved sorting, multi-selection, and workspace filtering.
HistoryView.tsx.HistoryView.tsx.HistoryView.tsx.HistoryView.tsx.useTaskSearchto support expanded filtering capabilities.HistoryView.test.tsxto reflect new sorting and filtering logic.CopyButton.tsxandHistoryPreview.tsxfor consistency.formatLargeNumberinformat.tsto use no decimal for thousands.This description was created by
for 77a2ae6. You can customize this summary. It will automatically update as commits are pushed.