Skip to content

Conversation

@sachasayan
Copy link
Contributor

@sachasayan sachasayan commented Apr 21, 2025

Context

Screenshot 2025-04-20 at 11 56 16 PM

  • General UX/UI Refinements on History View: Improved padding, improved iconography.
  • Dropdown for sorting instead of radio buttons.
  • Get rid of 'selection' mode in favour of always having tasks be multi-selectable.
  • Allow selectable workspaces instead of just "all" workspaces.
  • Modifications primarily to HistoryView.tsx, but this PR touches a few other files in mostly minor ways.
  • Notably, useTaskSearch was upgraded to expand filtering capabilities.
  • All functionality is preserved, just improved or re-styled. :)

Screenshot 2025-04-20 at 11 58 08 PM

Video

Screen.Recording.2025-04-20.at.11.48.17.PM.mov

Get in Touch

As always, InElement on Discord.


Important

Refined History View UI with improved sorting, multi-selection, and workspace filtering.

  • UI Enhancements:
    • Replaced radio buttons with a dropdown for sorting in HistoryView.tsx.
    • Improved padding and iconography in HistoryView.tsx.
    • Removed 'selection' mode; tasks are always multi-selectable in HistoryView.tsx.
  • Functionality:
    • Added workspace filtering options (current, all, selected) in HistoryView.tsx.
    • Enhanced useTaskSearch to support expanded filtering capabilities.
  • Testing:
    • Updated HistoryView.test.tsx to reflect new sorting and filtering logic.
  • Miscellaneous:
    • Minor changes in CopyButton.tsx and HistoryPreview.tsx for consistency.
    • Updated formatLargeNumber in format.ts to use no decimal for thousands.

This description was created by Ellipsis for 77a2ae6. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 001717e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sachasayan
Copy link
Contributor Author

Draft btw, do not merge. ✌️

@elianiva
Copy link
Contributor

hmm i'm not sure if it's good to remove selection mode and replace it with how it works in this PR, i'm expecting when you click on a task then it will open it

clicking while holding shift is more common i think, but to make users discover that without being too ambiguous or add another clutter like "hold shift to select" is something that needs figuring out

maybe keep the selection mode but automatically triggers it whenever one of the task is selected? no need to click "selection mode" manually
so you'd have a checkbox like how it was before—hidden by default, just like the other icons—but once the users click that, the entire card will be selectable, best of both worlds

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 22, 2025
@sachasayan
Copy link
Contributor Author

@elianiva Played around with this last night and tried a checkbox-based variant.... I didn't like it as much. Click target is too small, and/or you end up taking up more horizontal space. Gave it an honest shot, but the vibes weren't there. I'll push another commit in a bit (gotta fix some tests) but as a preview of what I've done to address some of the concerns:

  1. Action icons (trash, copy, export) don't go from opacity-0 to opacity-100 on hover. Instead, they go from opacity-50 to opacity-100. This means they're visible but they don't add too much visual repetition in the default state. It seems to work well as a compromise to me, I hope you agree.
  2. Switched to single select items by default. This makes them act more like a typical file system explorer. Click on, click off, and ctrl-click and shift-click if you want to select more items.
  3. Added more real estate to the navigate button. I think making the whole component a navigation button is a UX mistake tbh, but I agree you want the hit target on the larger size.

@sachasayan sachasayan force-pushed the UI/History-Refinement branch 2 times, most recently from 94a48df to 5fedaeb Compare April 29, 2025 22:14
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* initial

* added debounce for checkmark expanded ui

* corrected bookmark size

* removed unnecesary cleanup

* fixed removed code

* removed cleanup for real this time

* refactored to reduce complexity, added cleanup
@hannesrudolph hannesrudolph moved this from PR [Pre Approval Review] to PR [Draft/WIP] in Roo Code Roadmap May 10, 2025
Truncate workspace names.

History misc improvements.

Testing.
@sachasayan sachasayan force-pushed the UI/History-Refinement branch from 89dcf6e to 77a2ae6 Compare May 12, 2025 18:58
@sachasayan sachasayan marked this pull request as ready for review May 12, 2025 18:59
@sachasayan sachasayan requested review from cte and mrubens as code owners May 12, 2025 18:59
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels May 12, 2025
@sachasayan
Copy link
Contributor Author

This one's still here, ready to go.

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@mrubens
Copy link
Collaborator

mrubens commented May 21, 2025

For what it's worth my intuition is also that clicking on the history row should take you to the task, similar to how it works in the history preview.

@mrubens
Copy link
Collaborator

mrubens commented May 21, 2025

I think the rest of these changes are good, would just vote to bring back the selection as a secondary action instead of the primary action.

@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Changes Requested] in Roo Code Roadmap May 26, 2025
@daniel-lxs
Copy link
Member

I'll close this PR as stale, if someone else wants to work on this they can open a new PR.

@daniel-lxs daniel-lxs closed this Jun 9, 2025
@github-project-automation github-project-automation bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap Jun 9, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft/WIP] to Done in Roo Code Roadmap Jun 9, 2025
@elianiva elianiva mentioned this pull request Jun 14, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PR - Changes Requested size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants