Skip to content

Fix: Improve drag-and-drop and SSH path handling #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2025
Merged

Fix: Improve drag-and-drop and SSH path handling #2808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e96a9bb
Fix: Correct path handling for dragged files on Windows
NyxJae Apr 18, 2025
b2a58cc
Merge branch 'main' into Fix-drag-Tab
NyxJae Apr 21, 2025
4186403
Fix: Improve drag-and-drop and SSH path handling
NyxJae Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion webview-ui/src/components/chat/ChatTextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,10 @@ const ChatTextArea = forwardRef<HTMLTextAreaElement, ChatTextAreaProps>(
e.preventDefault()
setIsDraggingOver(false)

const text = e.dataTransfer.getData("application/vnd.code.uri-list")
const textFieldList = e.dataTransfer.getData("text")
const textUriList = e.dataTransfer.getData("application/vnd.code.uri-list")
// When textFieldList is empty, it may attempt to use textUriList obtained from drag-and-drop tabs; if not empty, it will use textFieldList.
const text = textFieldList || textUriList
if (text) {
// Split text on newlines to handle multiple files
const lines = text.split(/\r?\n/).filter((line) => line.trim() !== "")
Expand Down
16 changes: 14 additions & 2 deletions webview-ui/src/utils/path-mentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,20 @@
* @returns A mention-friendly path
*/
export function convertToMentionPath(path: string, cwd?: string): string {
// Strip file:// protocol if present
let pathWithoutProtocol = path.startsWith("file://") ? path.substring(7) : path
// Strip file:// or vscode-remote:// protocol if present
let pathWithoutProtocol = path

if (path.startsWith("file://")) {
pathWithoutProtocol = path.substring(7)
} else if (path.startsWith("vscode-remote://")) {
const protocolStripped = path.substring("vscode-remote://".length)
const firstSlashIndex = protocolStripped.indexOf("/")
if (firstSlashIndex !== -1) {
pathWithoutProtocol = protocolStripped.substring(firstSlashIndex + 1)
} else {
pathWithoutProtocol = ""
}
}

try {
pathWithoutProtocol = decodeURIComponent(pathWithoutProtocol)
Expand Down