-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Feat: Add a new button to import settings on the welcome screen #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add a new button to import settings on the welcome screen #2811
Conversation
…uiring to set an API key.
|
|
@cte do you mind taking a look at this? Agree that it makes sense to allow for settings import on the welcome screen somehow. Thanks! |
|
I think it should be more part of the onboarding flow (maybe a 2nd "OR" block, since it would pull in your keys too) wdyt @sachasayan @elianiva |
|
i prefer having something that's more visible, like a second OR block or some sort like Adam said currently it's using small text and users might miss them—due to themes and whatnot also having it on a separate section aligns with what we have now, so it'll give the impression of
at the moment i feel like it gives the impression of psst, here's the import settings button due to it being small we can also add some explanations if we decide to add it on its own section, like "importing settings will NOT import your api key" or something like that |
|
This is great and I'm fine with merging it as-is and doing another pass for UI improvements later. I agree this is a screen which could use some more love and I think a dedicated PR for that is best. Could you fix the failing tests, @julionav? Also, for anyone who knows: How much complexity is there in removing the provider from the proxy and keeping providerSettingsManager as source of truth for apiConfig, as mentioned in the code? |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
* Remove controllerRef * Remove webviewProviderRef * Remove controllerRef * Fix test * Create odd-jeans-wash.md * Fix test
Context
Right now you cannot import your settings into roo without adding a new API key #2208
Implementation
Added new button to
WelcomeView.tsxthat starts the import settings processUpdated import logic to set a provider in the
ContextProxy. This was required to allow the app to stop showing the welcome screen.ContextProxyandProviderSettingsManager-- I guess is code from Cline. Without the proivider inContextProxythe app thinks that no api has been configured, even though there are several API config in the providerScreenshots
How to Test
Get in Touch
Discord: profotium
Important
Add "Import Settings" button to welcome screen and update import logic to handle provider settings in
ContextProxy.WelcomeView.tsx.importSettingsinimportExport.tsto set provider settings inContextProxy.welcome.jsonfor multiple languages includingen,es,fr,de,zh-CN,zh-TW,hi,it,pl,pt-BR,vi, andca.This description was created by
for 6765bdd. You can customize this summary. It will automatically update as commits are pushed.