Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions src/core/webview/webviewMessageHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,37 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
await updateGlobalState("fuzzyMatchThreshold", message.value)
await provider.postStateToWebview()
break
case "updateVSCodeSetting": {
// Allowlist of VSCode settings that can be updated
// Add new settings here when needed for future expansion
const ALLOWED_VSCODE_SETTINGS = ["terminal.integrated.inheritEnv"] as const

if (message.setting && message.value !== undefined) {
if (!ALLOWED_VSCODE_SETTINGS.includes(message.setting as (typeof ALLOWED_VSCODE_SETTINGS)[number])) {
provider.log(`Attempted to update restricted VSCode setting: ${message.setting}`)
vscode.window.showErrorMessage(`Cannot update restricted VSCode setting: ${message.setting}`)
break
}
await vscode.workspace.getConfiguration().update(message.setting, message.value, true)
}
break
}
case "getVSCodeSetting":
if (message.setting) {
try {
const value = vscode.workspace.getConfiguration().get(message.setting)
await provider.postMessageToWebview({ type: "vsCodeSetting", setting: message.setting, value })
} catch (error) {
console.error(`Failed to get VSCode setting ${message.setting}:`, error)
await provider.postMessageToWebview({
type: "vsCodeSetting",
setting: message.setting,
error: `Failed to get setting: ${error.message}`,
value: undefined,
})
}
}
break
case "alwaysApproveResubmit":
await updateGlobalState("alwaysApproveResubmit", message.bool ?? false)
await provider.postStateToWebview()
Expand Down
4 changes: 4 additions & 0 deletions src/shared/ExtensionMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ export interface ExtensionMessage {
| "acceptInput"
| "setHistoryPreviewCollapsed"
| "commandExecutionStatus"
| "vsCodeSetting"
text?: string
action?:
| "chatButtonClicked"
Expand Down Expand Up @@ -104,6 +105,9 @@ export interface ExtensionMessage {
promptText?: string
results?: { path: string; type: "file" | "folder"; label?: string }[]
error?: string
setting?: string
value?: any
vscodeSettingValue?: unknown
}

export type ExtensionState = Pick<
Expand Down
5 changes: 5 additions & 0 deletions src/shared/WebviewMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ export interface WebviewMessage {
| "openFile"
| "openMention"
| "cancelTask"
| "updateVSCodeSetting"
| "getVSCodeSetting"
| "vsCodeSetting"
| "alwaysAllowBrowser"
| "alwaysAllowMcp"
| "alwaysAllowModeSwitch"
Expand Down Expand Up @@ -134,6 +137,7 @@ export interface WebviewMessage {
images?: string[]
bool?: boolean
value?: number
vscodeSettingValue?: unknown
commands?: string[]
audioType?: AudioType
serverName?: string
Expand All @@ -145,6 +149,7 @@ export interface WebviewMessage {
dataUrls?: string[]
values?: Record<string, any>
query?: string
setting?: string
slug?: string
modeConfig?: ModeConfig
timeout?: number
Expand Down
Loading