-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a JSONL implementation with benchmark and findings #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0c8aab5
Split api and chat message persistence into a separate module
cte 3e89c11
Split metadata generator out from file operation functions
cte f11db72
Add a JSONL implementation with benchmark and findings
cte 9a6fa38
Update src/core/task-persistence/taskMetadata.ts
cte d0add53
Fix file paths
cte de33481
Merge branch 'cte/task-persistence' into cte/task-persistence-jsonl
cte b9ecd4c
Merge branch 'main' into cte/task-persistence-jsonl
cte a566145
Revert these
cte 7dbbed0
Remove these
cte fc9d4f5
Add changeset
cte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "roo-cline": patch | ||
| --- | ||
|
|
||
| Add a JSONL version of task persistence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import * as path from "path" | ||
| import * as fs from "fs/promises" | ||
| import * as readline from "readline" | ||
| import { createReadStream } from "fs" | ||
|
|
||
| import { fileExistsAtPath } from "../../utils/fs" | ||
|
|
||
| import { GlobalFileNames } from "../../shared/globalFileNames" | ||
| import { ClineMessage } from "../../shared/ExtensionMessage" | ||
| import { getTaskDirectoryPath } from "../../shared/storagePathManager" | ||
|
|
||
| import type { ReadTaskMessagesOptions, SaveTaskMessagesOptions } from "./taskMessages" | ||
|
|
||
| export async function readTaskMessages({ | ||
| taskId, | ||
| globalStoragePath, | ||
| }: ReadTaskMessagesOptions): Promise<ClineMessage[]> { | ||
| const taskDir = await getTaskDirectoryPath(globalStoragePath, taskId) | ||
| const filePath = path.join(taskDir, `${GlobalFileNames.apiConversationHistory}l`) | ||
| const fileExists = await fileExistsAtPath(filePath) | ||
|
|
||
| if (!fileExists) { | ||
| return [] | ||
| } | ||
|
|
||
| const messages: ClineMessage[] = [] | ||
| const fileStream = createReadStream(filePath, { encoding: "utf8" }) | ||
| const rl = readline.createInterface({ input: fileStream, crlfDelay: Infinity }) | ||
|
|
||
| for await (const line of rl) { | ||
| if (line.trim()) { | ||
| messages.push(JSON.parse(line)) | ||
cte marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
|
|
||
| return messages | ||
| } | ||
|
|
||
| export async function writeTaskMessages({ messages, taskId, globalStoragePath }: SaveTaskMessagesOptions) { | ||
| const taskDir = await getTaskDirectoryPath(globalStoragePath, taskId) | ||
| const filePath = path.join(taskDir, `${GlobalFileNames.apiConversationHistory}l`) | ||
| const content = messages.map((message) => JSON.stringify(message)).join("\n") | ||
| await fs.writeFile(filePath, content) | ||
| } | ||
|
|
||
| export type AppendTaskMessageOptions = { | ||
| message: ClineMessage | ||
| taskId: string | ||
| globalStoragePath: string | ||
| } | ||
|
|
||
| export async function appendTaskMessage({ message, taskId, globalStoragePath }: AppendTaskMessageOptions) { | ||
| const taskDir = await getTaskDirectoryPath(globalStoragePath, taskId) | ||
| const filePath = path.join(taskDir, `${GlobalFileNames.apiConversationHistory}l`) | ||
| await fs.appendFile(filePath, JSON.stringify(message) + "\n") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import { findLastIndex } from "../../shared/array" | |
| import { HistoryItem } from "../../shared/HistoryItem" | ||
| import { getTaskDirectoryPath } from "../../shared/storagePathManager" | ||
|
|
||
| const taskSizeCache = new NodeCache({ stdTTL: 5 * 60, checkperiod: 30 }) | ||
| const taskSizeCache = new NodeCache({ stdTTL: 30, checkperiod: 5 * 60 }) | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I swapped these original; the TTL should be 30s and the check period doesn't really matter. |
||
|
|
||
| export type TaskMetadataOptions = { | ||
| messages: ClineMessage[] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.