Skip to content

feat(read_file): enhance file reading capabilities with multi-file support and improved parameter handling #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 30, 2025
Merged

feat(read_file): enhance file reading capabilities with multi-file support and improved parameter handling #2886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c4ee38d
feat(read_file): enhance file reading capabilities with multi-file su…
samhvw8 May 30, 2025
4e0b7be
fix the test
samhvw8 May 30, 2025
e59c5da
fix: normalize locale file formatting to use tabs
daniel-lxs May 30, 2025
118afad
fix(settings): improve checkbox handling and slider configuration in …
daniel-lxs May 30, 2025
720fb58
fix(read_file): enhance description to include partial reads support
daniel-lxs May 30, 2025
560d768
fix(read_file): update description for partial reads and improve exam…
daniel-lxs May 30, 2025
ca5648b
fix: suggestions
daniel-lxs May 30, 2025
fde7ba8
fix: translations
daniel-lxs May 30, 2025
9287e74
test: update system prompt snapshots for multi-file read tool
daniel-lxs May 30, 2025
250bb3c
fix: remove batch permission question from readFile tool translations
daniel-lxs May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/types/src/experiment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { Keys, Equals, AssertEqual } from "./type-fu.js"
* ExperimentId
*/

export const experimentIds = ["powerSteering"] as const
export const experimentIds = ["powerSteering", "concurrentFileReads"] as const

export const experimentIdsSchema = z.enum(experimentIds)

Expand All @@ -18,6 +18,7 @@ export type ExperimentId = z.infer<typeof experimentIdsSchema>

export const experimentsSchema = z.object({
powerSteering: z.boolean(),
concurrentFileReads: z.boolean(),
})

export type Experiments = z.infer<typeof experimentsSchema>
Expand Down
2 changes: 2 additions & 0 deletions packages/types/src/global-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const globalSettingsSchema = z.object({
allowedMaxRequests: z.number().nullish(),
autoCondenseContext: z.boolean().optional(),
autoCondenseContextPercent: z.number().optional(),
maxConcurrentFileReads: z.number().optional(),

browserToolEnabled: z.boolean().optional(),
browserViewportSize: z.string().optional(),
Expand Down Expand Up @@ -134,6 +135,7 @@ export const GLOBAL_SETTINGS_KEYS = keysOf<GlobalSettings>()([
"allowedMaxRequests",
"autoCondenseContext",
"autoCondenseContextPercent",
"maxConcurrentFileReads",

"browserToolEnabled",
"browserViewportSize",
Expand Down
4 changes: 2 additions & 2 deletions src/core/assistant-message/presentAssistantMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type { ToolParamName, ToolResponse } from "../../shared/tools"

import { fetchInstructionsTool } from "../tools/fetchInstructionsTool"
import { listFilesTool } from "../tools/listFilesTool"
import { readFileTool } from "../tools/readFileTool"
import { getReadFileToolDescription, readFileTool } from "../tools/readFileTool"
import { writeToFileTool } from "../tools/writeToFileTool"
import { applyDiffTool } from "../tools/applyDiffTool"
import { insertContentTool } from "../tools/insertContentTool"
Expand Down Expand Up @@ -153,7 +153,7 @@ export async function presentAssistantMessage(cline: Task) {
case "execute_command":
return `[${block.name} for '${block.params.command}']`
case "read_file":
return `[${block.name} for '${block.params.path}']`
return getReadFileToolDescription(block.name, block.params)
case "fetch_instructions":
return `[${block.name} for '${block.params.task}']`
case "write_to_file":
Expand Down
Loading