Refactor: Extract focus logic in DiffViewProvider #2905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maintains editor view column state when closing and reopening files during diff operations, ensuring tabs stay opened in their original position. - Prevents closing the original editor tab when opening the diff view, preserving pinned status when applying changes via write_to_file or apply_diff. - Updates VSCode workspace launch flag from -n to -W for compatibility.
|
dosubot
bot
added
the
size:M
Contributor
|
Thanks for following up with an ellipsis bot comment post merge! |
Contributor
|
Needs an update to resolve conflicts @seedlord . 😇 |
hannesrudolph
moved this from PR [Pre Approval Review]
to PR [Draft/WIP]
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Draft/WIP]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Removed redundant code
Implementation
As suggested by ellipsis-dev in #2857 (comment)
Screenshots
not needed
How to Test
not needed
Get in Touch
https://discord.com/users/201009672675786752
Important
Refactored focus logic in
DiffViewProvider.tsby extracting it into_focusOriginalDocument()and updated a VSCode command-line argument inindex.ts._focusOriginalDocument()inDiffViewProvider.tsto reduce code duplication._focusOriginalDocument()calls insaveChanges()andrevertChanges().-nto-Winindex.ts.This description was created by
for 394bc1b. You can customize this summary. It will automatically update as commits are pushed.