-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix: ChatTextArea's height moving unexcepted when Roo Code width change #2969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
@sachasayan thoughts on this? |
|
Nice. Looks good. Any specific reason to go from 100px to 90px? Just tightening things up a little bit @zhangtony239 ? |
|
So here's the thing: I made some slight adjustments, and 90px happens to look just right visually on my end—not too wide. Considering that this text box automatically adjusts its height when there are multiple lines, I think it gives off a 'the question I’m asking the AI isn’t that complicated' vibe, which feels more friendly. (And it’s bidirectional — LLMs indeed struggle with breaking down very complex problems, which remains a challenge in boomerang mode.) Of course, this is just a custom tweak based on my own 2560x1600 screen with 175% scaling, so please feel free to change it if it causes any discomfort! |
|
If it's okay, this is ready to merge. @mrubens |
…ge (RooCodeInc#2969) Fix: ChatTextArea's height moving unexcepted when Roo Code width change.
…ooCodeInc#2969) * fix:The POST requests of MCP's SSE server support setting headers.(RooCodeInc#2652) * fix:The POST requests of MCP's SSE server support setting headers.(RooCodeInc#2652) --------- Co-authored-by: Toshii <[email protected]>
Context
Fix ChatTextArea height's unexcepted moving, which recorded in Screenshots.
Unplanned Changes
When I was coding this PR, ESLint told me that the
event: MouseEventwasn't used, so I removed it after scanning the whole file with Roo (Gemini 2.5 Flash) in order to pass the check.Chat history: roo_task_apr-26-2025_5-43-00-pm.md, please review it again!
Screenshots
How to Test
Get in Touch
Discord: zhangtony239
Important
Fixes unexpected height change in
ChatTextAreawhen Roo Code width changes and removes unusedMouseEventparameter for ESLint compliance.ChatTextAreawhen Roo Code width changes by adjusting CSS classes to ensure consistent minimum height.event: MouseEventparameter fromhandleClickOutsidefunction to satisfy ESLint checks.This description was created by
for 98530d1776b390ff6044ed185cb6be6d4a1bbad9. You can customize this summary. It will automatically update as commits are pushed.