Skip to content

Conversation

@zhangtony239
Copy link
Contributor

@zhangtony239 zhangtony239 commented Apr 26, 2025

Context

Fix ChatTextArea height's unexcepted moving, which recorded in Screenshots.

Unplanned Changes

When I was coding this PR, ESLint told me that the event: MouseEvent wasn't used, so I removed it after scanning the whole file with Roo (Gemini 2.5 Flash) in order to pass the check.

Chat history: roo_task_apr-26-2025_5-43-00-pm.md, please review it again!

Screenshots

before after
https://github.com/user-attachments/assets/b690f859-7fe2-4aff-930f-754f51844bfc https://github.com/user-attachments/assets/a35c2863-f255-429c-bed3-1ff06c779e25

How to Test

  • Run this version
  • Drag to change Roo Code's width
  • You will see the change showed in Screenshots.

Get in Touch

Discord: zhangtony239


Important

Fixes unexpected height change in ChatTextArea when Roo Code width changes and removes unused MouseEvent parameter for ESLint compliance.

  • Behavior:
    • Fixes unexpected height change in ChatTextArea when Roo Code width changes by adjusting CSS classes to ensure consistent minimum height.
  • Code Quality:
    • Removes unused event: MouseEvent parameter from handleClickOutside function to satisfy ESLint checks.

This description was created by Ellipsis for 98530d1776b390ff6044ed185cb6be6d4a1bbad9. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2025

⚠️ No Changeset found

Latest commit: 63c929d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 26, 2025
@mrubens
Copy link
Collaborator

mrubens commented Apr 28, 2025

@sachasayan thoughts on this?

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 28, 2025
@sachasayan sachasayan self-assigned this Apr 28, 2025
@sachasayan
Copy link
Contributor

Nice. Looks good. Any specific reason to go from 100px to 90px? Just tightening things up a little bit @zhangtony239 ?

@zhangtony239
Copy link
Contributor Author

So here's the thing: I made some slight adjustments, and 90px happens to look just right visually on my end—not too wide. Considering that this text box automatically adjusts its height when there are multiple lines, I think it gives off a 'the question I’m asking the AI isn’t that complicated' vibe, which feels more friendly. (And it’s bidirectional — LLMs indeed struggle with breaking down very complex problems, which remains a challenge in boomerang mode.)

Of course, this is just a custom tweak based on my own 2560x1600 screen with 175% scaling, so please feel free to change it if it causes any discomfort!

@zhangtony239
Copy link
Contributor Author

If it's okay, this is ready to merge. @mrubens

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 2, 2025
@mrubens mrubens merged commit 6a6443e into RooCodeInc:main May 2, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from PR [Pre Approval Review] to Done in Roo Code Roadmap May 2, 2025
mehmetsunkur pushed a commit to mehmetsunkur/Roo-Code that referenced this pull request May 16, 2025
…ge (RooCodeInc#2969)

Fix: ChatTextArea's height moving unexcepted when Roo Code width change.
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
…ooCodeInc#2969)

* fix:The POST requests of MCP's SSE server support setting headers.(RooCodeInc#2652)

* fix:The POST requests of MCP's SSE server support setting headers.(RooCodeInc#2652)

---------

Co-authored-by: Toshii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants