Skip to content

Conversation

@KJ7LNW
Copy link
Contributor

@KJ7LNW KJ7LNW commented Apr 27, 2025

Context

Run linting checks alongside tests to catch style and formatting issues before pushing code or creating PRs. This helps developers identify and fix issues earlier in their workflow.

Implementation

Modified scripts/run-tests.js to:

  • Add lint:* to npm test command execution
  • Maintain parallel execution on non-Windows systems

How to Test

  1. Make a change that would fail linting (e.g. add trailing whitespace)
  2. Run npm test
  3. Verify that linting errors are reported alongside test results

Get in Touch

Discord: KJ7LNW


Important

Include linting in npm test command in scripts/run-tests.js to catch style issues early.

  • Behavior:
    • Modifies scripts/run-tests.js to include lint:* in npm test command.
    • Ensures linting errors are reported alongside test results.
    • Maintains parallel execution on non-Windows systems.
  • Testing:
    • To test, introduce a linting error and run npm test to verify error reporting.

This description was created by Ellipsis for dcf7bc7. You can customize this summary. It will automatically update as commits are pushed.

Run linting checks alongside tests to catch style and formatting issues before pushing code or creating PRs, saving developers time by identifying problems earlier.

- Added lint:* to npm test command execution
- Maintains parallel execution on non-Windows systems

Signed-off-by: Eric Wheeler <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2025

⚠️ No Changeset found

Latest commit: dcf7bc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2025
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer enhancement New feature or request labels Apr 27, 2025
@mrubens mrubens merged commit 0549a02 into RooCodeInc:main Apr 28, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 28, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants