Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Apr 29, 2025

Context

I think there are too many actions, and the input prompt seems unnecessary; the VSCode diagnostics already tell the model exactly what's wrong so it knows what to do.

Before:

Screenshot 2025-04-28 at 11 12 11 PM Screenshot 2025-04-28 at 11 12 21 PM

After:

When language server diagnostics are present:
Screenshot 2025-04-28 at 11 10 38 PM

Otherwise:
Screenshot 2025-04-29 at 12 11 02 AM


Important

Simplifies Roo Code's quick actions by removing unnecessary prompts and commands, updating command handling, and adjusting related tests and UI components.

  • Behavior:
    • Removed unnecessary input prompts for quick actions in registerCodeActions.ts and registerTerminalActions.ts.
    • Simplified command registration by removing registerCodeActionPair and registerTerminalActionPair functions.
    • Updated handleCodeAction and handleTerminalAction in ClineProvider.ts to handle simplified actions.
  • Commands:
    • Removed roo-cline.terminalFixCommandInCurrentTask and roo-cline.terminalExplainCommandInCurrentTask from package.json and related localization files.
    • Updated command registration in registerCommands.ts to reflect removed commands.
  • Tests:
    • Skipped Roo Code Subtasks test suite in subtasks.test.ts.
    • Updated CodeActionProvider.test.ts to reflect changes in available actions.
  • Misc:
    • Updated CodeActionProvider.ts to remove createActionPair and adjust provideCodeActions logic.
    • Minor refactoring in ChatView.tsx to handle UI changes related to quick actions.

This description was created by Ellipsis for 1454e35. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025

⚠️ No Changeset found

Latest commit: 1454e35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Apr 29, 2025
@adamhill
Copy link
Contributor

adamhill commented Apr 29, 2025

Q: Are the Commands still able to be keybound?
I have found " Explain Code" to be useful, it will get more useful when Daniels code indexing PR lands

@cte
Copy link
Collaborator Author

cte commented Apr 29, 2025

Q: Are the Commands still able to be keybound? I have found " Explain Code" to be useful, it will get more useful when Daniels code indexing PR lands

It's only the "Quick Fix" options when language server diagnostics are available that seems overbearing; I ended up keeping "Improve" / "Explain" / etc in the default case.

import { sleep, waitFor, waitUntilCompleted } from "./utils"

suite("Roo Code Subtasks", () => {
suite.skip("Roo Code Subtasks", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid leaving tests permanently skipped unless strictly necessary. If skipping is temporary, please add a comment explaining why and a TODO to re-enable the test.

@cte cte merged commit d07e605 into main Apr 29, 2025
12 checks passed
@cte cte deleted the cte/quick-fix-actions branch April 29, 2025 15:07
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 29, 2025
@utapyngo
Copy link

utapyngo commented May 5, 2025

This is a good improvement!
However, I want to clean up my context menus.

Is there an option to hide the remaining two actions?

SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* Fix: Increase Ollama provider timeout from 30s to 120s

* Add changeset for Ollama provider timeout fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants