-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat improve custom mode with customize objective, rule & capabilities #3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The pull request contains a variety of changes, including new features, tests, documentation, and refactoring. While these changes are substantial, they appear to be interconnected, focusing on improving the custom mode with new objectives, rules, and capabilities. However, if there are distinct groups of changes that can be logically separated without affecting the overall functionality, consider splitting the pull request into smaller ones. For example, documentation updates could be separated from feature additions if they do not directly depend on each other. This can help streamline the review process and ensure each set of changes is thoroughly evaluated. Please review the changes and assess if any sections can be independently split into separate pull requests. |
src/core/prompts/system.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 75 refers to 'Pug templates', but the code actually loads EJS templates (objective.ejs, rules.ejs, capabilities.ejs). Consider updating the comment to accurately reflect that these are EJS templates.
| // Load default Pug templates | |
| // Load default EJS templates |
a91e970 to
126566e
Compare
Now objective, rule & capabilities can be template via ejs
126566e to
9a6d174
Compare
|
Thanks for submitting this PR—really appreciate your effort here, and sorry it's been sitting in draft status for so long. We're closing this for now but would love to see this idea move forward. Please start by creating an issue using our issue-first approach. This way, we can have the dev team properly review and approve the proposal before you resubmit a PR. Thanks again for your patience and contribution! |
Now custom mode can customize objective, rule & capabilities can be template via ejs
Context
When tool has remove from custom mode but sometime Roo still want access to there tool because those tool are mentioned in objective, rule & capabilities section.
This pr will address above problems
Implementation
Screenshots
How to Test
Get in Touch
Important
Enhance custom modes with EJS template support for objectives, rules, and capabilities, including schema updates, UI changes, and tests.
objective,rules, andcapabilitiessections using EJS templates insrc/core/prompts/templates.copyEjsTemplatesplugin inesbuild.jsto copy EJS templates todist/templates.renderEjs.ts.modeConfigSchemainschemas/index.tsto includeobjectiveSectionOverride,rulesSectionOverride, andcapabilitiesSectionOverride.GlobalSettingsandPromptComponenttypes intypes.tsandroo-code.d.ts.PromptsView.tsxto allow editing of new override sections.prompts.json.custom-system-prompt.test.tsto verify new override functionality.This description was created by
for c9013fc2437eead3c69441e3d7e7b1caf8a2dc21. You can customize this summary. It will automatically update as commits are pushed.