Skip to content

Conversation

@KJ7LNW
Copy link
Contributor

@KJ7LNW KJ7LNW commented Apr 30, 2025

Context

Adds streaming diff UI for:

  • apply_diff
  • insert_content
  • search_and_replace (pending)

you might think these should be separate pull requests, but they will benefit from some shared functionality to reduce duplicate code, so they need to be the single PR.

Implementation

  • Add streaming support for partial diff updates
  • Enhance insert content tool with improved error handling and validation
  • Add telemetry for tracking insert content errors
  • Improve UI responsiveness and feedback during operations
  • Add consecutive mistake tracking for better error messaging
  • Optimize diff view streaming and auto-scroll behavior

How to Test

  • Use insert_content tool with various inputs to verify error handling
  • Check diff streaming updates in the UI for responsiveness
  • Verify error messages appear after multiple consecutive mistakes
  • Test auto-scroll behavior during streaming updates

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 01b9399

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 1, 2025
@hannesrudolph hannesrudolph moved this from PR [Pre Approval Review] to PR [Draft/WIP] in Roo Code Roadmap May 10, 2025
@KJ7LNW KJ7LNW force-pushed the feat-add-diff-edit-streaming branch from 818d50a to 6fd2aa7 Compare May 11, 2025 00:56
Eric Wheeler added 4 commits May 16, 2025 18:37
Add streaming support with partial content display and improve error handling:
- Validate inputs before processing
- Show clear error messages for missing files
- Support diff view streaming updates
- Maintain file context during partial updates
- Fix line number validation

Signed-off-by: Eric Wheeler <[email protected]>
- Add streaming support for partial diff updates
- Add auto-scroll control to diff view provider
- Improve loading state handling in code accordion
- Enhance error handling and feedback for failed diffs
- Optimize UI responsiveness during streaming updates

Signed-off-by: Eric Wheeler <[email protected]>
- Add consecutive mistake tracking for insert content operations
- Add telemetry for insert content errors with PostHog integration
- Add rooIgnore validation check
- Add line numbers to final content output
- Show error messages only after 2+ consecutive mistakes
- Match error handling patterns from applyDiffTool

Signed-off-by: Eric Wheeler <[email protected]>
- Use askApproval helper for consistent feedback handling with applyDiffTool
- Fix line number display to be 1-based in messages
- Remove redundant error message since askApproval handles feedback

Signed-off-by: Eric Wheeler <[email protected]>
@hannesrudolph
Copy link
Collaborator

stale

@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft/WIP] to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants