-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add File Attachment Capability to new_task Tool #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f530ca3
feat: add new parameters to the new_task tool to allow files to be at…
daniel-lxs 0fc399b
feat: show files attached in subtask block and allow line ranges
daniel-lxs c37fe98
feat: open file and line range if available when clicking the badges
daniel-lxs 49606f1
tests: update snapshot for system prompt
daniel-lxs 2be78a9
refactor: add a default value for attached files in the state
daniel-lxs c39451f
fix: use correct types
daniel-lxs c8018e7
feat: move read file logic to shared file
daniel-lxs fb37034
test: update tests to accomodate to the new split logic
daniel-lxs 533d9e9
docs: commit to retrigger tests
daniel-lxs fe2387e
fix: outdated imports
daniel-lxs b79bbc1
Merge branch 'main' into attach-files-new-task
daniel-lxs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
144 changes: 132 additions & 12 deletions
144
src/core/prompts/__tests__/__snapshots__/system.test.ts.snap
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #2886 and work with @samhvw8 so that are line range formats do not diverge; multiple range formats would probably confuse the model across tools.
Gemini and Claude have both been shown empirically tested that the following format used in #2886 works very well for the model. this is a real life example:
standardizing XML representation will simplify it tool class refactors in the future