Improve performance of CustomModesManager #3123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Using a noisy terminal command I was able to get Roo into a state where it was performing extremely poorly due to excessive calls to
postStateToWebview. When I profiled the app a few things stood out, but this was the lowest hanging fruit. ThegetCustomModescall is slow, and we were calling it twice in row instead of just using the first result.Important
Improve
CustomModesManagerperformance by implementing caching forgetCustomModes()with cache invalidation and TTL handling.CustomModesManagerforgetCustomModes()with a TTL of 10 seconds to reduce redundant file reads.cachedModesandcachedAtproperties toCustomModesManager.clearCache()method toCustomModesManagerto handle cache invalidation.getCustomModes()to utilize caching logic.CustomModesManager.test.tsto verify caching behavior, including cache invalidation on updates and deletions, and TTL expiration.CustomModesManager.tsfor code clarity.ClineProvider.tsto use cachedcustomModesinpostStateToWebview().This description was created by
for 431d4c0. You can customize this summary. It will automatically update as commits are pushed.