Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 2, 2025

Context

  • Don't change the terminal settings when VSCode terminal integration fails
  • Make the chat warning pop less
Screenshot 2025-05-02 at 9 14 13 AM

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Improves command execution by refining terminal integration handling and updating UI and localization for better user communication.

  • Behavior:
    • Removed setting terminalShellIntegrationDisabled to true in executeCommandTool() when VSCode terminal integration fails.
    • Updated shell integration warning message in chat.json across multiple locales to provide clearer instructions.
  • UI:
    • Added border to CommandExecution component in CommandExecution.tsx.
    • Changed background color and border in CommandExecutionError.tsx for better visibility.
  • Localization:
    • Updated shellIntegration warning title and description in chat.json for ca, de, en, es, fr, hi, it, ja, ko, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW locales.

This description was created by Ellipsis for 2deb097. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 2deb097

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 2, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented May 2, 2025

It looks like this pull request includes both command execution improvements and translation updates across multiple language files. To make the review process more manageable, could you consider splitting the translation updates into a separate pull request? This way, we can focus on the command execution changes separately from the localization updates. Thank you!

@cte cte merged commit 19ef52b into main May 2, 2025
17 checks passed
@cte cte deleted the cte/more-command-execution-improvements branch May 2, 2025 21:51
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 2, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* createRuleFile protobus migration

* deleteRuleFile protobus

* mend

* mend

* mend

* ellipsis changes

* Generic response for delete request

* refactored deleteRuleFile for consolidation

* rename ruleFileResult to ruleFile
mehmetsunkur pushed a commit to mehmetsunkur/Roo-Code that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants