Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 3, 2025

Context

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Reverts commit 2e66081, undoing changes to command execution, terminal process management, and related UI components.

  • Behavior:
    • Reverts changes to executeCommandTool() in executeCommandTool.ts, affecting command execution flow and error handling.
    • Reverts changes to ExecaTerminalProcess in ExecaTerminalProcess.ts, affecting process management and signal handling.
    • Reverts changes to commandExecutionStatusSchema in index.ts, affecting status tracking.
  • UI Components:
    • Reverts changes to ChatRow.tsx and CommandExecution.tsx, affecting UI display of command execution results.
  • Utilities:
    • Reverts changes to combineCommandSequences.ts, affecting command and output message handling.

This description was created by Ellipsis for 8a80ccc. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2025

⚠️ No Changeset found

Latest commit: 8a80ccc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 3, 2025
<div className="rounded-full size-1.5 bg-lime-400" />
<div>Running</div>
{status.pid && <div className="whitespace-nowrap">(PID: {status.pid})</div>}
<Button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an aria-label (e.g. aria-label="Abort command") to the abort Button for improved accessibility.

</div>
)}
{lines.length > 0 && (
<Button variant="ghost" size="icon" onClick={() => setIsExpanded(!isExpanded)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an aria-expanded attribute to the toggle Button so that its expanded state is communicated to assistive technologies.

Suggested change
<Button variant="ghost" size="icon" onClick={() => setIsExpanded(!isExpanded)}>
<Button variant="ghost" size="icon" aria-expanded={isExpanded} onClick={() => setIsExpanded(!isExpanded))}>

@cte cte closed this May 4, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 4, 2025
@cte cte deleted the cte/revert-2e660819 branch May 4, 2025 02:18
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* Fix unit test set-up

* run tests on CI

* update failing tests

* Update node

Update the coverage job node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants