ui/ux feat: add right-click menu item (jump to last checkpoint) #3160
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| import { ClineMessage } from "@roo/shared/ExtensionMessage" | ||
| import React from "react" // Added missing React import for RefObject | ||
|
|
||
| // --- findPreviousCheckpointIndex function (existing, correct) --- | ||
| export function findPreviousCheckpointIndex( | ||
| messages: (ClineMessage | ClineMessage[])[], | ||
| currentCheckpointTs: number, | ||
| ): number { | ||
| // ... (implementation as previously read) ... | ||
| console.log("Finding previous checkpoint for ts:", currentCheckpointTs) | ||
| const currentIndex = messages.findIndex( | ||
| (item) => !Array.isArray(item) && item.say === "checkpoint_saved" && item.ts === currentCheckpointTs, | ||
| ) | ||
| console.log("Current checkpoint index:", currentIndex) | ||
| if (currentIndex <= 0) { | ||
| console.log("No previous checkpoint found (current is first or not found)") | ||
| return -1 | ||
| } | ||
| for (let i = currentIndex - 1; i >= 0; i--) { | ||
| const item = messages[i] | ||
| if (!Array.isArray(item) && item.say === "checkpoint_saved") { | ||
| console.log("Found previous checkpoint at index:", i) | ||
| return i | ||
| } | ||
| } | ||
| console.log("No previous checkpoint found after searching") | ||
| return -1 | ||
| } | ||
|
|
||
| // --- findLastCheckpointIndex function (existing, correct) --- | ||
| export function findLastCheckpointIndex(messages: (ClineMessage | ClineMessage[])[]): number { | ||
| // ... (implementation as previously read) ... | ||
| console.log("Finding last checkpoint in message list") | ||
| for (let i = messages.length - 1; i >= 0; i--) { | ||
| const item = messages[i] | ||
| if (!Array.isArray(item) && item.say === "checkpoint_saved") { | ||
| console.log("Found last checkpoint at index:", i) | ||
| return i | ||
| } | ||
| } | ||
| console.log("No checkpoint found in message list") | ||
| return -1 | ||
| } | ||
|
|
||
| // --- jumpToLastCheckpoint function (existing, correct) --- | ||
| export function jumpToLastCheckpoint( | ||
| virtuosoRef: React.RefObject<any>, | ||
|
Contributor
There was a problem hiding this comment. Consider using a more specific type rather than This comment was generated because it violated a code review rule: mrule_QkEwsCio7v34DaCF. |
||
| messages: (ClineMessage | ClineMessage[])[], | ||
| onScrollComplete?: () => void, | ||
| ): boolean { | ||
| // ... (implementation as previously read) ... | ||
| console.log("Jump to last checkpoint requested") | ||
| const lastCheckpointIndex = findLastCheckpointIndex(messages) | ||
| if (lastCheckpointIndex !== -1) { | ||
| jumpToCheckpoint(virtuosoRef, lastCheckpointIndex, onScrollComplete) | ||
| return true | ||
| } | ||
| console.log("No checkpoint found to jump to") | ||
| return false | ||
| } | ||
|
|
||
| // --- jumpToCheckpoint function (existing, correct) --- | ||
| export function jumpToCheckpoint( | ||
| virtuosoRef: React.RefObject<any>, | ||
| index: number, | ||
| onScrollComplete?: () => void, | ||
| ): void { | ||
| // ... (implementation as previously read) ... | ||
| console.log("Jump to checkpoint called with index:", index) | ||
| if (index !== -1 && virtuosoRef.current) { | ||
| console.log("Virtuoso ref exists, attempting to scroll to index:", index) | ||
| virtuosoRef.current.scrollToIndex({ | ||
| index: index, | ||
| align: "start", | ||
| behavior: "smooth", | ||
| }) | ||
| console.log("Scroll to index command sent to Virtuoso") | ||
| if (onScrollComplete) { | ||
| setTimeout(onScrollComplete, 500) // Allow time for smooth scroll | ||
| } | ||
| } else { | ||
| console.log("Cannot jump: index is -1 or virtuosoRef is null", { | ||
| index, | ||
| virtuosoRefExists: !!virtuosoRef.current, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| // --- jumpToPreviousCheckpoint function (existing, correct, optional for this feature) --- | ||
| export function jumpToPreviousCheckpoint( | ||
| virtuosoRef: React.RefObject<any>, | ||
| messages: (ClineMessage | ClineMessage[])[], | ||
| currentCheckpointTs?: number, | ||
| onScrollComplete?: () => void, | ||
| ): boolean { | ||
| // ... (implementation as previously read) ... | ||
| console.log("Jump to previous checkpoint requested") | ||
| let targetIndex: number | ||
| if (currentCheckpointTs) { | ||
| console.log("Current checkpoint timestamp:", currentCheckpointTs) | ||
| targetIndex = findPreviousCheckpointIndex(messages, currentCheckpointTs) | ||
| } else { | ||
| console.log("No current checkpoint, finding last checkpoint") | ||
| targetIndex = findLastCheckpointIndex(messages) | ||
| } | ||
| if (targetIndex !== -1) { | ||
| jumpToCheckpoint(virtuosoRef, targetIndex, onScrollComplete) | ||
| return true | ||
| } | ||
| console.log("No previous checkpoint found to jump to") | ||
| return false | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider internationalizing the command title for 'jumpToLastCheckpoint' (e.g., using a placeholder similar to other commands) to ensure consistency with other user-facing texts.
This comment was generated because it violated a code review rule: mrule_JLtLS6tLppVEv8iV.