Add mode permissions for new_task, switch_mode and ask_followup_questions #3171

cannuri · 2025-05-04T22:54:56Z

Context

This PR introduces a more granular permission system for specific tools (new_task, switch_mode, ask_followup_question) and adds a mechanism (slugRegex) to restrict which modes can be targeted by new_task and switch_mode.

It is now possible to restrict a mode's ability to create subtasks, switch modes or ask followup question. Furthermore you can also define which modes are available for a subtask or for switching by defining slugRegex (just like defining fileRegex)

WHY:

Allows users to define more precisely how modes can interact with each other. This allows to define workflows since you can tell Code mode for example that it has to call Test mode afterwards. Also you can restrict Architect mode from switching to Coding for example.
Now it is possible to force Orchestrator to create a subtask instead of switching modes (as it would do that from time to time which unnecessarily bloats the context window)
Sometimes you don't want to be asked any followup questions but let Roo Code run on auto pilot. You can turn off follow up questions for specific modes now.
Aligns permissions for mode interaction tools with existing patterns like fileRegex for file editing.

Implementation

This feature was implemented by introducing new permission groups (subtask, switch, followup) in the schema and shared tool configurations. The corresponding tools (new_task, switch_mode, ask_followup_question) were moved under these groups, removing them from being always available.

The core permission checking logic in isToolAllowedForMode was updated to handle these new groups. For the subtask and switch groups, an optional slugRegex property was added to the schema (groupOptionsSchema) and the checking logic was enhanced to parse tool parameters (mode or mode_slug) and validate them against the provided regex, denying the tool use if the target mode slug doesn't match.

The Prompts UI (PromptsView.tsx) was updated to display checkboxes for the new permissions. Logic was added to interpret the slugRegex and display the names of allowed modes in the UI, formatted differently for collapsed (Names...) and expanded Allowed modes: ... views (just like "Edit Files" is styled). This required accessing the list of all available modes within the component.

Localization keys were added to prompts.json files for the new permission names and the "Allowed modes:" text. Default permissions were enabled for built-in modes. Comprehensive tests (logic, UI, schema) were added and updated throughout the process, following TDD principles where appropriate. External documentation was also updated.

Screenshots

Before

After

How to Test

Check UI:
- Open the Prompts settings view.
- Select a custom mode (or create one).
- Verify the new checkboxes "Create Subtasks", "Switch Modes", and "Ask Follow-up Questions" appear.
Test slugRegex:
- Edit the .roomodes file for a custom mode.
- Add the subtask permission using the tuple format with a slugRegex, e.g., [ "subtask", { "slugRegex": "^(code|test)$" } ].
- Save the file.
- Go back to the Prompts UI and view the custom mode's details.
- Verify Collapsed View: Check that "Create Subtasks" now shows (Code, Test) next to it.
- Click "Edit tools".
- Verify Expanded View: Check that Allowed modes: Code, Test appears below the "Create Subtasks" checkbox.
- Start a chat using this custom mode.
- Try creating a subtask:
  - Use <new_task><mode>code</mode>...</new_task>. This should succeed.
  - Use <new_task><mode>ask</mode>...</new_task>. This should fail (the tool use should be rejected by the backend based on isToolAllowedForMode).
- Repeat the process for the switch permission and the switch_mode tool.

Get in Touch

Discord: can.nuri

Important

This PR adds a granular permission system for specific tools, updates the UI to support these changes, and includes tests and localization updates.

Permissions:
- Introduces new permission groups subtask, switch, followup in schemas/index.ts.
- Updates isToolAllowedForMode in modes.ts to handle new groups and slugRegex.
UI:
- Updates PromptsView.tsx to display new permissions with checkboxes and interpret slugRegex.
- Adds localization keys for new permissions in prompts.json files.
Tests:
- Adds tests for new permissions and slugRegex logic in modes.test.ts and PromptsView.test.tsx.
Misc:
- Updates toolGroups in tools.ts to include new groups.
- Removes new_task, switch_mode, ask_followup_question from ALWAYS_AVAILABLE_TOOLS.

^{This description was created by}^{for 7f2e046. You can customize this summary. It will automatically update as commits are pushed.}

changeset-bot · 2025-05-04T22:54:59Z

⚠️ No Changeset found

Latest commit: 66fa269

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cannuri · 2025-05-04T23:31:34Z

I had to change the layout structure from a grid to a flex column to prevent layout issues.
When the "Allowed modes: ..." list become too long, it broke the styling. See:

ellipsis-dev · 2025-05-04T23:34:29Z

webview-ui/src/i18n/locales/tr/prompts.json

 			"command": "Komutları Çalıştır",
-			"mcp": "MCP Kullan"
+			"mcp": "MCP Kullan",
+			"subtask": "Alt görevler oluştur",


For consistency with the other tool name translations (e.g., 'Dosyaları Oku', 'Dosyaları Düzenle', 'Tarayıcı Kullan', 'MCP Kullan'), consider capitalizing the first letters of each word in the newly added strings. For example, change 'Alt görevler oluştur' to 'Alt Görevler Oluştur', 'Modları değiştir' to 'Modları Değiştir', and 'Takip soruları sor' to 'Takip Soruları Sor'. This way, all similar UI labels use the same style.

Suggested change

"subtask": "Alt görevler oluştur",

"subtask": "Alt Görevler Oluştur",

mrubens · 2025-05-05T21:16:11Z

src/exports/roo-code.d.ts

+							"read" | "edit" | "browser" | "command" | "mcp" | "subtask" | "switch" | "followup",
 							{
 								fileRegex?: string | undefined
+								slugRegex?: string | undefined


Let me see if I change my mind after reading the whole diff, but I think an array of slugs might make more sense than a regex here.

Yeah, still think an array of slugs would be easier to manage.

mrubens · 2025-05-05T21:19:43Z

webview-ui/src/components/prompts/PromptsView.tsx


+										// Check if the group should be always available and thus potentially non-editable
+										// For now, we allow editing all for custom modes as per test requirements
+										const isDisabled = !isCustomMode // || TOOL_GROUPS[group].alwaysAvailable;


Suggested change

const isDisabled = !isCustomMode // || TOOL_GROUPS[group].alwaysAvailable;

const isDisabled = !isCustomMode

mrubens · 2025-05-05T21:21:05Z

webview-ui/src/components/prompts/PromptsView.tsx

+											const matchingNames = getMatchingModeNames(options.slugRegex, modes)
+											if (matchingNames.length > 0) {
+												// Format for expanded view: Allowed modes: Name1, Name2
+												description = `${t("prompts:tools.allowedModes")}: ${matchingNames.join(", ")}`


We should either remove the colon from the end of the translations or from here - it's showing up as a double colon currently.

mrubens

I think we also need to update the system prompt to remove the tools if they're not allowed in the mode, and probably also to tell the model which modes it can switch to / start a new task with.

mrubens · 2025-05-05T21:24:42Z

webview-ui/src/i18n/locales/en/prompts.json

+			"mcp": "Use MCP",
+			"subtask": "Create Subtasks",
+			"switch": "Switch Modes",
+			"followup": "Ask Follow-up Questions"


I think "Ask Questions" is a more obvious label here

mrubens · 2025-05-05T21:25:47Z

I wonder if we should start by just adding the 3 new checkboxes without the allowed modes and get that solid, and then do the mode restrictions in a follow-up PR?

cannuri · 2025-05-05T22:41:25Z

I wonder if we should start by just adding the 3 new checkboxes without the allowed modes and get that solid, and then do the mode restrictions in a follow-up PR?

Sure, I can take that out. Which option do you prefer? The array or to leave it out for now?

mrubens · 2025-05-05T22:44:12Z

I wonder if we should start by just adding the 3 new checkboxes without the allowed modes and get that solid, and then do the mode restrictions in a follow-up PR?

Sure, I can take that out. Which option do you prefer? The array or to leave it out for now?

I think leave it out for now, since I think there’s a little prompt engineering involved to make sure the model knows what it’s allowed to do

cannuri · 2025-05-05T22:54:47Z

I wonder if we should start by just adding the 3 new checkboxes without the allowed modes and get that solid, and then do the mode restrictions in a follow-up PR?

Sure, I can take that out. Which option do you prefer? The array or to leave it out for now?

I think leave it out for now, since I think there’s a little prompt engineering involved to make sure the model knows what it’s allowed to do

Wouldn't be so hard to add that and I was thinking about it but decided against because file restrictions are also not mentioned in the prompt and also I tried to avoid adding more token.

Alright, will remove it.

* refactor to not pass message for showMcpView * changeset

cannuri · 2025-05-08T02:52:01Z

@mrubens please wait with your review until I give you a go

cannuri · 2025-05-23T10:11:32Z

How do you think we should handle backwards compatibility on this? For instance the custom orchestrators that people have written?

I will have a look into that. pretty busy these days, sorry.

cannuri · 2025-05-23T10:14:04Z

@cannuri @mrubens

Would it make sense to switch from a whitelist to a blacklist for available tools and migrate the custom modes as well? This approach would allow us to infer which tools the user expects to be available while also enabling users to exclude tools they don't want enabled for any mode. The UI would not require any changes.

So you mean we should extend it and allow blacklisting any available tool? Actually I would also prefer the ability to disable any tool, even read_file if someone likes to. @mrubens what do you think about that?

daniel-lxs · 2025-05-23T13:38:58Z

@cannuri
The main issue is backwards compatibility, if the user is currently expecting new_task and switch_mode to be available, then you'll have to manually add them to the available tools list by default, basically migrating the settings so nothing breaks.

cannuri · 2025-05-23T14:05:13Z

@cannuri The main issue is backwards compatibility, if the user is currently expecting new_task and switch_mode to be available, then you'll have to manually add them to the available tools list by default, basically migrating the settings so nothing breaks.

Yeah get u. Therefore u meant blacklisting instead of whitelisting. But we could also auto migrate their .roomodes

hannesrudolph · 2025-05-27T18:08:49Z

Thanks for your patience on this PR.

We need to either land the plane on this soon or shift the discussion back to an issue to clearly agree on the scope and details before implementation. Given the time elapsed since the changes were requested, let's determine whether to wrap this up quickly or close it and revisit through our issue-first approach.

Let us know how you'd like to proceed.

cannuri · 2025-05-30T20:25:00Z

Thanks for your patience on this PR.

We need to either land the plane on this soon or shift the discussion back to an issue to clearly agree on the scope and details before implementation. Given the time elapsed since the changes were requested, let's determine whether to wrap this up quickly or close it and revisit through our issue-first approach.

Let us know how you'd like to proceed.

we need to decide if we want to just extend this directly to all available tools (which i would prefer).

also need to decide on blacklisting vs whitelisting
@daniel-lxs maybe we can have a chat on this these days?

daniel-lxs · 2025-05-30T20:27:06Z

Hey @cannuri, Sure! I think the best idea is to create an issue for this since that's what we will be checking first from now on.
There we (and the rest of the community) can discuss the best way to tackle this.

cannuri · 2025-05-30T20:37:07Z

Hey @cannuri, Sure! I think the best idea is to create an issue for this since that's what we will be checking first from now on. There we (and the rest of the community) can discuss the best way to tackle this.

@daniel-lxs yep makes sense 👍
Can be closed then

daniel-lxs · 2025-05-30T20:39:19Z

Closing temporarily

whkt · 2025-08-18T07:17:16Z

Any idea if this, or at least the feature to disable ask_followup_question, will be released? I have some usecases where Roo automatically run and, though clearly instructed not to use ask_followup_question, some mode still uses it causing the whole workflow to be stalled. I usually run Roo in isolated docker env and not look at it for hours. A lot of time, I come back seeing Roo haven't started anything due to stuck at asking a non-relevant question

cannuri added 2 commits May 4, 2025 20:49

Add mode permissions for new_task, switch_mode, ask_followup_question

b7c9805

Add slugRegex for mode restriction on subtask/switch

129f273

github-project-automation bot added this to Roo Code Roadmap May 4, 2025

github-project-automation bot moved this to New in Roo Code Roadmap May 4, 2025

fix style issue when list of allowed modes is too long

7f2e046

cannuri marked this pull request as ready for review May 4, 2025 23:31

cannuri requested review from cte and mrubens as code owners May 4, 2025 23:31

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels May 4, 2025

ellipsis-dev bot reviewed May 4, 2025

View reviewed changes

mrubens self-assigned this May 5, 2025

hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap May 5, 2025

mrubens reviewed May 5, 2025

View reviewed changes

mrubens requested changes May 5, 2025

View reviewed changes

mrubens reviewed May 5, 2025

View reviewed changes

SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025

Remove showMcpView message (RooCodeInc#3171)

5294e78

* refactor to not pass message for showMcpView * changeset

remove slugRegex filter

cf6a4dc

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels May 8, 2025

Some style fixes

66fa269

github-project-automation bot moved this to New in Roo Code Roadmap May 20, 2025

hannesrudolph moved this from New to PR [Greenlit] in Roo Code Roadmap May 20, 2025

daniel-lxs moved this from PR [Ready to Merge] to PR [Changes Requested] in Roo Code Roadmap May 27, 2025

daniel-lxs added the PR - Changes Requested label May 27, 2025

hannesrudolph closed this May 27, 2025

github-project-automation bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap May 27, 2025

github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap May 27, 2025

hannesrudolph reopened this May 27, 2025

github-project-automation bot moved this from Done to Triage in Roo Code Roadmap May 27, 2025

github-project-automation bot moved this from Done to New in Roo Code Roadmap May 27, 2025

hannesrudolph moved this from Triage to PR [Changes Requested] in Roo Code Roadmap May 27, 2025

hannesrudolph marked this pull request as draft May 27, 2025 18:08

hannesrudolph moved this from PR [Changes Requested] to PR [Draft / In Progress] in Roo Code Roadmap May 27, 2025

hannesrudolph unassigned mrubens May 27, 2025

hannesrudolph added PR - Draft / In Progress and removed PR - Changes Requested labels May 27, 2025

daniel-lxs closed this May 30, 2025

github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap May 30, 2025

github-project-automation bot moved this from New to Done in Roo Code Roadmap May 30, 2025

cannuri mentioned this pull request May 30, 2025

Granular permissions for new_task, switch_mode, and ask_followup_question (and more?) #4156

Closed

4 tasks

	"subtask": "Alt görevler oluştur",
	"subtask": "Alt Görevler Oluştur",

	const isDisabled = !isCustomMode // \|\| TOOL_GROUPS[group].alwaysAvailable;
	const isDisabled = !isCustomMode

Add mode permissions for new_task, switch_mode and ask_followup_questions #3171

Add mode permissions for new_task, switch_mode and ask_followup_questions #3171

Uh oh!

Conversation

cannuri commented May 4, 2025 • edited by ellipsis-dev bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Implementation

Screenshots

How to Test

Get in Touch

Uh oh!

changeset-bot bot commented May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

cannuri commented May 4, 2025

Uh oh!

ellipsis-dev bot May 4, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens May 5, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens May 5, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens May 5, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens May 5, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

mrubens May 5, 2025

Choose a reason for hiding this comment

Uh oh!

mrubens commented May 5, 2025

Uh oh!

cannuri commented May 5, 2025

Uh oh!

mrubens commented May 5, 2025

Uh oh!

cannuri commented May 5, 2025

Uh oh!

cannuri commented May 8, 2025

Uh oh!

cannuri commented May 23, 2025

Uh oh!

cannuri commented May 23, 2025

Uh oh!

daniel-lxs commented May 23, 2025

Uh oh!

cannuri commented May 23, 2025

Uh oh!

hannesrudolph commented May 27, 2025

Uh oh!

cannuri commented May 30, 2025

Uh oh!

daniel-lxs commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cannuri commented May 30, 2025

Uh oh!

daniel-lxs commented May 30, 2025

Uh oh!

whkt commented Aug 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cannuri commented May 4, 2025 •

edited by ellipsis-dev bot

Loading

changeset-bot bot commented May 4, 2025 •

edited

Loading

daniel-lxs commented May 30, 2025 •

edited

Loading