Skip to content

Conversation

@Mnehmos
Copy link
Contributor

@Mnehmos Mnehmos commented May 6, 2025

Context

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Replace npm-run-all with npm-run-all2 in package.json for improved security and reduced maintenance.

  • Dependencies:
    • Replace npm-run-all with npm-run-all2 in package.json to improve security and reduce maintenance.
    • Update install:all script to use npm-run-all2.
  • Changeset:
    • Add .changeset/replace-npm-run-all.md to document the change.

This description was created by Ellipsis for 33ccf51. You can customize this summary. It will automatically update as commits are pushed.

Mnehmos added 2 commits May 5, 2025 18:58
This PR addresses issue #3190 by replacing npm-run-all with npm-run-all2.

Changes made:
- Updated all script commands in package.json to use npm-run-all2
- Changed the devDependency from "npm-run-all": "^4.1.5" to "npm-run-all2": "^5.0.0"
- Added a changeset file to document this change

Benefits:
- Reduced maintenance burden: npm-run-all2 is a fork with troublesome babel code removed
- Improved security: Includes dependabot updates for better dependency management
- Better automation: Release automation is enabled in npm-run-all2
- Same functionality: Provides the same CLI commands and API as the original package

This is a minimal change that should have no impact on existing functionality.
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 33ccf51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 6, 2025
"build:esbuild": "node esbuild.js --production",
"compile": "tsc -p . --outDir out && node esbuild.js",
"install:all": "npm install npm-run-all && npm-run-all -l -p install-*",
"install:all": "npm install npm-run-all2 && npm-run-all -l -p install-*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'install:all' script now installs 'npm-run-all2' but still calls 'npm-run-all'. Verify that the new package provides a binary alias compatible with 'npm-run-all', or update the command invocation accordingly.

Suggested change
"install:all": "npm install npm-run-all2 && npm-run-all -l -p install-*",
"install:all": "npm install npm-run-all2 && npm-run-all2 -l -p install-*",

@Mnehmos Mnehmos closed this by deleting the head repository May 6, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 7, 2025
@hannesrudolph hannesrudolph moved this from New to Done in Roo Code Roadmap May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant