-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add weighted threshold calculation for fuzzy search similarity #3207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
…ance getWeightedThreshold logic and add tests
…de into weighted-threshold
|
Hey @fede-ciliberti, we apologive for taking so long to review your PR. We recently added a test for the multi search replace tool on #2220. Do you think it is a good idea to use this to test your implementation? Let me know what you think. |
|
Stale |
This pull request introduces several updates to the multi-search-replace strategy in
src/core/diff/strategies/multi-search-replace.ts. Key changes include the addition of a weighted threshold for fuzzy matching, improvements to error reporting, and enhanced documentation for the diff format. These updates aim to make the fuzzy search more adaptive, improve error clarity, and ensure proper usage of the diff format.Enhancements to Fuzzy Matching:
getWeightedThresholdfunction to dynamically adjust the fuzzy match threshold based on the text length, ensuring better adaptability for varying content sizes.Improvements to Error Reporting:
Documentation and Formatting Updates:
Minor Adjustments:
searchChunkinput by removing trailing newlines to prevent mismatches during fuzzy search.Important
Add weighted threshold for fuzzy matching in
multi-search-replace.ts, enhance error reporting, and expand diff format documentation.getWeightedThresholdfunction inmulti-search-replace.tsto adjust threshold based on text length.searchChunkinput by removing trailing newlines infuzzySearch().This description was created by
for 8df5d92. You can customize this summary. It will automatically update as commits are pushed.