Improve diagnostics fetching after file edits #3243
Conversation
|
dosubot
bot
added
the
size:L
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| // Get diagnostics before editing the file, we'll compare to diagnostics | ||
| // after editing to see if Roo needs to fix anything. | ||
| this.preDiagnostics = vscode.languages.getDiagnostics() | ||
| console.log(`preDiagnostics: ${JSON.stringify(this.preDiagnostics)}`) |
There was a problem hiding this comment.
Consider replacing console.log with structured logging for consistency and production-readiness.
| console.log(`preDiagnostics: ${JSON.stringify(this.preDiagnostics)}`) | |
| logger.info(`preDiagnostics: ${JSON.stringify(this.preDiagnostics)}`) |
This comment was generated because it violated a code review rule: mrule_OR1S8PRRHcvbdFib.
| const problems = fileDiagnostics.filter((d) => severities.includes(d.severity)) | ||
|
|
||
| if (problems.length > 0) { | ||
| result += `\n\n${path.relative(cwd, uri.fsPath).toPosix()}` |
There was a problem hiding this comment.
Calling .toPosix() on a string is non‐standard. Consider using path.posix.relative or a dedicated utility for POSIX path conversion.
| result += `\n\n${path.relative(cwd, uri.fsPath).toPosix()}` | |
| result += `\n\n${path.posix.relative(cwd, uri.fsPath)}` |
cte
changed the title
dosubot
bot
added
size:XL
* added posthog remote config * changeset * add feature flags constant * move init outside function to keep from potentially re-running --------- Co-authored-by: Elephant Lumps <[email protected]>
|
stale |
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
Context
I noticed that the latency in language servers can cause false positives when reporting diagnostics to the LLM. Let's wait for them to stabilize before returning after editing files.
Important
Improved diagnostics handling in
DiffViewProviderby polling for stabilization and updatedsetup.shfor cleaner repository management.DiffViewProvider.ts, addedpollDiagnosticsUntilStabilized()to poll diagnostics until they stabilize, replacing the previous fixed delay approach.saveChanges()to use the new polling method for diagnostics.setup.shand directly clone the repository.git cleancommand insetup.shto ensure a clean state before pulling updates.index.tsandDiffViewProvider.tsfor consistency.index.tsfor clarity.This description was created by
for 468413d. You can customize this summary. It will automatically update as commits are pushed.