Skip to content

fix: Prevent terminal focus theft on paste after command execution #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

fix: Prevent terminal focus theft on paste after command execution #3356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
264017d
fix: Prevent terminal focus theft on paste after command execution
MuriloFP May 8, 2025
883e1f6
Merge branch 'RooVetGit:main' into prevent-terminal-focus-shift
MuriloFP May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/tools/executeCommandTool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export async function executeCommand(
const terminal = await TerminalRegistry.getOrCreateTerminal(workingDir, !!customCwd, cline.taskId, terminalProvider)

if (terminal instanceof Terminal) {
terminal.terminal.show()
terminal.terminal.show(true)
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an inline comment explaining that passing true to terminal.terminal.show(true) prevents terminal focus theft on paste, which assists future maintainers in understanding the rationale.

Suggested change
terminal.terminal.show(true)
terminal.terminal.show(true) // Passing 'true' prevents terminal focus theft on paste, aiding future maintainers.

This comment was generated because it violated a code review rule: mrule_aQsEnH8jWdOfHq2Z.


// Update the working directory in case the terminal we asked for has
// a different working directory so that the model will know where the
Expand Down