Skip to content

Conversation

@KrabsWong
Copy link

@KrabsWong KrabsWong commented May 10, 2025

Expand the line-height of markdown block view to avoid overcrowding the content

Related GitHub Issue

Closes: #3437

Description

Content of the markdown view is so crowed.

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Previews screenshout
image

After change the line-height
image

Documentation Updates

Additional Notes


Important

Adjust line-height for list elements in MarkdownBlock.tsx to improve readability.

  • Style Change:
    • Adjust line-height from 1.25 to 1.75 for li, ol, ul in StyledMarkdown in MarkdownBlock.tsx to improve readability.

This description was created by Ellipsis for bcf25a9aa2f991abef7bdaea43ac19e1c3bf372d. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2025

⚠️ No Changeset found

Latest commit: 373d2aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 10, 2025
@huajiankan
Copy link

Devil in details. Make Roo-Code Greater Again :)

@adamhill
Copy link
Contributor

I like the improved readability. But some people will want the density.

1.25x seems like the minimum viable spacing - Would you entertain adding a slider in settings between 1.25 and 2.0x.

Thanks for helping out with old eyes

@KrabsWong
Copy link
Author

I like the improved readability. But some people will want the density.

1.25x seems like the minimum viable spacing - Would you entertain adding a slider in settings between 1.25 and 2.0x.

Thanks for helping out with old eyes

Good idea, I'll try to add a new setting section for UI Settings with a slider for setting the line-height of markdown view
New PR will be pulled soon.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 10, 2025
@KrabsWong KrabsWong closed this May 10, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 10, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 10, 2025
@KrabsWong KrabsWong mentioned this pull request May 15, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants